[issue24326] Audioop: weightB not divided by GCD, weightA divided twice

Serhiy Storchaka added the comment: Thank you Arfrever. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue24326] Audioop: weightB not divided by GCD, weightA divided twice

Roundup Robot added the comment: New changeset 7d6a6028b104 by Serhiy Storchaka in branch '2.7': Fixed test_audioop for issue #24326. https://hg.python.org/cpython/rev/7d6a6028b104 -- ___ Python tracker ___

[issue24326] Audioop: weightB not divided by GCD, weightA divided twice

Arfrever Frehtes Taifersar Arahesis added the comment: The changed test passes on 3.4 branch, but fails on 2.7 branch: $ python2.7 -m test.test_audioop test_add (__main__.TestAudioop) ... ok test_adpcm2lin (__main__.TestAudioop) ... ok test_alaw2lin (__main__.TestAudioop) ... ok test_avg (__main

[issue24326] Audioop: weightB not divided by GCD, weightA divided twice

Serhiy Storchaka added the comment: Thank you for your report and patch David. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue24326] Audioop: weightB not divided by GCD, weightA divided twice

Roundup Robot added the comment: New changeset 800a55c20b56 by Serhiy Storchaka in branch '3.4': Issue #24326: Fixed audioop.ratecv() with non-default weightB argument. https://hg.python.org/cpython/rev/800a55c20b56 New changeset 418ab34fd1ce by Serhiy Storchaka in branch '2.7': Issue #24326: Fi

[issue24326] Audioop: weightB not divided by GCD, weightA divided twice

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka stage: -> patch review versions: +Python 2.7, Python 3.4, Python 3.5 ___ Python tracker _

[issue24326] Audioop: weightB not divided by GCD, weightA divided twice

New submission from David Moore: Hi - During a code review of Modules/audioop.c I noted that weightB is never divided by the GCD while weightA is divided twice. This is contrary to the comment and appears to be a bug: /* divide weightA and weightB by their greatest common divisor */