[issue23992] multiprocessing: MapResult shouldn't fail fast upon exception

Changes by Charles-François Natali : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue23992] multiprocessing: MapResult shouldn't fail fast upon exception

Roundup Robot added the comment: New changeset 1ba0deb52223 by Charles-François Natali in branch 'default': Issue #23992: multiprocessing: make MapResult not fail-fast upon exception. https://hg.python.org/cpython/rev/1ba0deb52223 -- nosy: +python-dev ___

[issue23992] multiprocessing: MapResult shouldn't fail fast upon exception

Davin Potts added the comment: As an aside: issue24948 seems to show there are others who would find the immediate-multiple-error_callback idea attractive. -- ___ Python tracker __

[issue23992] multiprocessing: MapResult shouldn't fail fast upon exception

Changes by Davin Potts : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23992] multiprocessing: MapResult shouldn't fail fast upon exception

Davin Potts added the comment: The patches make good sense to me -- I have no comments to add in a review. I spent more time than I care to admit concerned with the idea that error_callback (exposed by map_async which map sits on top of) should perhaps be called not just once at the end but ea

[issue23992] multiprocessing: MapResult shouldn't fail fast upon exception

Davin Potts added the comment: @neologix: Budgeting time this week to have a proper look -- sorry I haven't gotten back to it sooner. -- ___ Python tracker ___ _

[issue23992] multiprocessing: MapResult shouldn't fail fast upon exception

Charles-François Natali added the comment: Barring any objections, I'll commit within the next few days. -- ___ Python tracker ___ ___

[issue23992] multiprocessing: MapResult shouldn't fail fast upon exception

Changes by Charles-François Natali : -- keywords: +needs review nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue23992] multiprocessing: MapResult shouldn't fail fast upon exception

Changes by Charles-François Natali : Added file: http://bugs.python.org/file39172/mp_map_fail_fast_27.diff Added file: http://bugs.python.org/file39173/mp_map_fail_fast_default.diff ___ Python tracker _

[issue23992] multiprocessing: MapResult shouldn't fail fast upon exception

Changes by Charles-François Natali : Removed file: http://bugs.python.org/file39171/mp_map_fail_fast_default.diff ___ Python tracker ___ ___ P

[issue23992] multiprocessing: MapResult shouldn't fail fast upon exception

Changes by Charles-François Natali : Removed file: http://bugs.python.org/file39170/mp_map_fail_fast_27.diff ___ Python tracker ___ ___ Python

[issue23992] multiprocessing: MapResult shouldn't fail fast upon exception

Charles-François Natali added the comment: Patches for 2.7 and default. -- keywords: +patch Added file: http://bugs.python.org/file39170/mp_map_fail_fast_27.diff Added file: http://bugs.python.org/file39171/mp_map_fail_fast_default.diff ___ Python tra

[issue23992] multiprocessing: MapResult shouldn't fail fast upon exception

Davin Potts added the comment: This is a nice example demonstrating what I agree is a problem with the current implementation of close. A practical concern with what I believe is being proposed in your trivial fix: if the workers are engaged in very long-running tasks (and perhaps slowly wri

[issue23992] multiprocessing: MapResult shouldn't fail fast upon exception

Changes by Ned Deily : -- nosy: +davin, sbt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue23992] multiprocessing: MapResult shouldn't fail fast upon exception

New submission from Charles-François Natali: hanger.py """ from time import sleep def hang(i): sleep(i) raise ValueError("x" * 1024**2) """ The following code will deadlock on pool.close(): """ from multiprocessing import Pool from time import sleep from hanger import hang with Poo