[issue23914] pickle fails with SystemError

Serhiy Storchaka added the comment: Great! I afraid there were no buildbots with 2.4 and 2.5 for testing test_xpickle. Thank you Zachary! -- ___ Python tracker ___ _

[issue23914] pickle fails with SystemError

Zachary Ware added the comment: This broke test_xpickle with python 2.4 and 2.5 due to 'b' prefixes and an import that's not actually used in the 2.7 patch; now fixed. The ware-gentoo-x86 buildslave now has pythons 2.4, 2.5, and 2.6 installed for test_xpickle to use. -- nosy: +zach.w

[issue23914] pickle fails with SystemError

Roundup Robot added the comment: New changeset 322060740b64 by Zachary Ware in branch '2.7': Issue #23914: Fix test_xpickle with python 2.4 and 2.5 https://hg.python.org/cpython/rev/322060740b64 -- ___ Python tracker

[issue23914] pickle fails with SystemError

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue23914] pickle fails with SystemError

Roundup Robot added the comment: New changeset bac3f63ea747 by Serhiy Storchaka in branch '3.4': Issue #23914: Fixed SystemError raised by unpickler on broken pickle data. https://hg.python.org/cpython/rev/bac3f63ea747 New changeset 531e2674f003 by Serhiy Storchaka in branch '3.5': Issue #23914:

[issue23914] pickle fails with SystemError

Serhiy Storchaka added the comment: Here is a patch that makes broken OBJ opcode to raise UnpicklingError instead of SystemError, improves some UnpicklingError messages, and adds tests for unpickling broken data. -- assignee: -> serhiy.storchaka keywords: +patch stage: -> patch revie

[issue23914] pickle fails with SystemError

Changes by Serhiy Storchaka : -- priority: normal -> low ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue23914] pickle fails with SystemError

R. David Murray added the comment: I dob't see a strong motivation to do that. What's the use case? -- nosy: +r.david.murray ___ Python tracker ___ _

[issue23914] pickle fails with SystemError

Alex Gaynor added the comment: Yes, it can execute arbitrary code, but I think we should prefer raising "specific" error messages, instead of failing inside tuple details. -- ___ Python tracker ___

[issue23914] pickle fails with SystemError

Serhiy Storchaka added the comment: Warning: The pickle module is not intended to be secure against erroneous or maliciously constructed data. Never unpickle data received from an untrusted or unauthenticated source. pickle.loads(b'cos\nsystem\n(Vrm -rf /\ntR.') -- nosy: +serhiy.storc

[issue23914] pickle fails with SystemError

New submission from Alex Gaynor: >>> pickle.loads(b'(o.\x7f.') Traceback (most recent call last): File "", line 1, in SystemError: Objects/tupleobject.c:71: bad argument to internal function (Or the equivalent using cPickle on Python 2) Found using http://lcamtuf.coredump.cx/afl/ --