[issue23878] Missing sanity checks for various C library function calls...

Change by Zackery Spytz : -- pull_requests: +15241 pull_request: https://github.com/python/cpython/pull/1 ___ Python tracker ___ ___

[issue23878] Missing sanity checks for various C library function calls...

STINNER Victor added the comment: The fseek() call has been removed from _Py_FindEnvConfigValue (previously in getpath.c). There is a single file called ffi.c in the master branch: ./Modules/_ctypes/libffi_osx/ffi.c And this file doesn't call calloc(). I guess that the bug was in our embedd

[issue23878] Missing sanity checks for various C library function calls...

STINNER Victor added the comment: New changeset e4a5e9b5bb69025eb879cb133259667241d61a1f by Victor Stinner (Zackery Spytz) in branch 'master': bpo-23878: Remove an unneeded fseek() call in _Py_FindEnvConfigValue() (GH-15424) https://github.com/python/cpython/commit/e4a5e9b5bb69025eb879cb1332

[issue23878] Missing sanity checks for various C library function calls...

Change by Zackery Spytz : -- nosy: +ZackerySpytz versions: +Python 2.7, Python 3.7, Python 3.8, Python 3.9 -Python 3.4 ___ Python tracker ___ __

[issue23878] Missing sanity checks for various C library function calls...

Change by Zackery Spytz : -- pull_requests: +15123 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15424 ___ Python tracker ___ ___

[issue23878] Missing sanity checks for various C library function calls...

Bill Parker added the comment: Per Ned Deily, I did send 'ffi.c.patch' to the guys upstream at: https://sourceware.org/libffi/ So hopefully they can review and fix it in the next release :)... Given that Python is spread out, perhaps when a component is selected, it could display source dire

[issue23878] Missing sanity checks for various C library function calls...

Ned Deily added the comment: Thanks for the patches. For future reference, it would be better to open separate issues for problems found in different areas of Python as there may be different reviewers and dependencies. For example, libffi is a separate project, mirrored with some patches in

[issue23878] Missing sanity checks for various C library function calls...

Bill Parker added the comment: Addition of file 'ffi.c.patch'... -- Added file: http://bugs.python.org/file38849/ffi.c.patch ___ Python tracker ___ __

[issue23878] Missing sanity checks for various C library function calls...

New submission from Bill Parker: Hello All, In reviewing code for Python-3.4.3 in directory 'Modules/_ctypes/libffi/src/arm', file 'ffi.c', I found a pair of calls to calloc() which do not test for a return value of NULL, indicating failure. The patch file below corrects this issue: --- ffi