[issue23753] Drop HAVE_FSTAT: require fstat() to compile/use Python

STINNER Victor added the comment: > -#if defined(HAVE_STAT) && !defined(MS_WINDOWS) > This doesn't look correct. An equivalent replacement is Oh, I missed the "!". Only _Py_wstat() uses this test. Windows has _wstat(), so _Py_wstat() could use it. I added deliberately "!defined(MS_WINDOWS)" b

[issue23753] Drop HAVE_FSTAT: require fstat() to compile/use Python

Roundup Robot added the comment: New changeset ad5521dd7b80 by Victor Stinner in branch 'default': Issue #23753: Move _Py_wstat() from Python/fileutils.c to Modules/getpath.c https://hg.python.org/cpython/rev/ad5521dd7b80 -- ___ Python tracker

[issue23753] Drop HAVE_FSTAT: require fstat() to compile/use Python

Serhiy Storchaka added the comment: > -#if defined(HAVE_STAT) && !defined(MS_WINDOWS) This doesn't look correct. An equivalent replacement is -#if defined(HAVE_STAT) && !defined(MS_WINDOWS) +#if !defined(MS_WINDOWS) -- ___ Python tracker

[issue23753] Drop HAVE_FSTAT: require fstat() to compile/use Python

Roundup Robot added the comment: New changeset a84eae63b4cd by Victor Stinner in branch 'default': Issue #23753: Python doesn't support anymore platforms without stat() or https://hg.python.org/cpython/rev/a84eae63b4cd -- nosy: +python-dev ___ Python

[issue23753] Drop HAVE_FSTAT: require fstat() to compile/use Python

STINNER Victor added the comment: Antoine and Charles-François are in favor of removing these #ifdef. Serhiy wrote: > See issue22623 for moving in opposite direction. Not exactly, Link Mauve wrote "On those two platforms, fstat() is correctly defined and works fine, so it shouldn’t be a proble

[issue23753] Drop HAVE_FSTAT: require fstat() to compile/use Python

Charles-François Natali added the comment: > Serhiy Storchaka added the comment: > > See also issue12082. Yes, but I don't think we want to clutter the code to support exotic niche platforms. -- ___ Python tracker

[issue23753] Drop HAVE_FSTAT: require fstat() to compile/use Python

Serhiy Storchaka added the comment: See also issue12082. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue23753] Drop HAVE_FSTAT: require fstat() to compile/use Python

Charles-François Natali added the comment: +1 from me, fstat() has always been par of POSIX. It's really likely Python won't build anyway on such systems. -- ___ Python tracker _

[issue23753] Drop HAVE_FSTAT: require fstat() to compile/use Python

STINNER Victor added the comment: My changes only *removes* code and so make it simpler ;-) $ diffstat stat.patch Include/fileutils.h |6 -- Include/pyport.h | 22 -- Modules/_io/fileio.c | 20 Modules/mmapmodule.c |4 Python/f

[issue23753] Drop HAVE_FSTAT: require fstat() to compile/use Python

Serhiy Storchaka added the comment: See issue22623 for moving in opposite direction. -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue23753] Drop HAVE_FSTAT: require fstat() to compile/use Python

Changes by STINNER Victor : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue23753] Drop HAVE_FSTAT: require fstat() to compile/use Python

STINNER Victor added the comment: stat.patch: Stop pretending that Python works without stat() nor fstat(), consider that these functions are always available. -- keywords: +patch Added file: http://bugs.python.org/file38660/stat.patch ___ Python tra

[issue23753] Drop HAVE_FSTAT: require fstat() to compile/use Python

New submission from STINNER Victor: Topic previously discussed at: https://mail.python.org/pipermail/python-dev/2013-May/126285.html Related issue: http://bugs.python.org/issue12082 Antoine Pitrou wrote in the issue: "I would personally like to remove HAVE_FSTAT and make Python unconditionally