[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Tim Peters added the comment: Thank you for your persistence and patience, Peter! It shouldn't have been this hard for you :-( -- ___ Python tracker ___ ___

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Peter Law added the comment: Awesome, thanks for fixing this. -- nosy: +PeterJCLaw ___ Python tracker ___ ___ Python-bugs-list mailing

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Changes by Alexander Belopolsky : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Alexander Belopolsky added the comment: OK, I have no idea how I managed to create two commits in 3.4 and 3.5 and loose the NEWS entry in the end. -- ___ Python tracker ___

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Roundup Robot added the comment: New changeset ff68705c56a8 by Alexander Belopolsky in branch '3.4': Closes issue #23600: Wrong results from tzinfo.fromutc(). https://hg.python.org/cpython/rev/ff68705c56a8 New changeset c706c062f545 by Alexander Belopolsky in branch '3.5': Closes issue #23600: W

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Alexander Belopolsky added the comment: I give up. Somehow my changes conflict with parent: 98335:0d3b64bbc82c user:Serhiy Storchaka date:Sun Sep 27 22:38:33 2015 +0300 summary: Issue #25203: Failed readline.set_completer_delims() no longer left the and my knowledge

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Tim Peters added the comment: Afraid that's a question for python-dev - I lost track of the active branches over year ago :-( -- ___ Python tracker ___ _

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Alexander Belopolsky added the comment: Thanks, Tim. Now I need to figure out how to commit to multiple branches. This goes to 3.4 through 3.6, right? or just to 3.5 and 3.6. -- components: +Extension Modules -Library (Lib) ___ Python tracker

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Tim Peters added the comment: Patch looks good to me! Thanks :-) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Alexander Belopolsky added the comment: Attaching a patch that should fix the issue. -- keywords: +patch stage: needs patch -> commit review versions: +Python 3.4, Python 3.5 Added file: http://bugs.python.org/file40603/issue23600.diff ___ Python trac

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Alexander Belopolsky added the comment: It looks like I introduced this bug ~ 5 years ago when I made a switch from integer minutes offset to an arbitrary timedelta. It's rather amazing that it took so long to discover it. -- ___ Python tracker

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Changes by Alexander Belopolsky : -- assignee: -> belopolsky stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Tim Peters added the comment: I expect Peter is correct: the C fromutc() doesn't match the logic of the Python fromutc(), and there are no comments explaining why the C version changed the logic. The last 4 lines of his `time_issues.py` show the difference. The simplified UKSummerTime tzinf

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Alexander Belopolsky added the comment: I am afraid you misunderstand how fromutc() method works. Note that you rarely need to call it directly: use astimezone() method to convert between timezones. -- nosy: +tim.peters ___ Python tracker

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Changes by Alexander Belopolsky : -- versions: +Python 3.6 -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Changes by Alistair Lynn : -- nosy: +alynn ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Peter J C Law added the comment: Hi, Sorry for the overkill demo. I've attached a much shorter version, the key portion of which seems to be that, for the case of UK summer time the timezone, the tzinfo's `dst()` and `utcoffset()` methods return the same value. This results in the delta betwe

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Alexander Belopolsky added the comment: Peter, Can you attach your demo script to the issue? Better yet, is it possible to explain the issue without referring to 100 lines of code? -- ___ Python tracker

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

Changes by Ned Deily : -- nosy: +belopolsky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue23600] tizinfo.fromutc changed for tzinfo wih StdOffset=0, DstOffset=1

New submission from Peter J C Law: There's a difference in behaviour between the ``fromutc`` method on a tzinfo between Python 2 and Python 3, though only under the specific case of Summer Time in regions whose usual offset is 0. >From what I can tell, it's the Python 3 one which is wrong, bas