[issue23366] integer overflow in itertools.combinations

Roundup Robot added the comment: New changeset 887526ebb013 by Serhiy Storchaka in branch '2.7': Issues #23363, #23364, #23365, #23366: Fixed itertools overflow tests. https://hg.python.org/cpython/rev/887526ebb013 -- ___ Python tracker

[issue23366] integer overflow in itertools.combinations

Changes by Arfrever Frehtes Taifersar Arahesis : -- versions: +Python 2.7, Python 3.3, Python 3.5 ___ Python tracker ___ ___ Python-bu

[issue23366] integer overflow in itertools.combinations

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue23366] integer overflow in itertools.combinations

Roundup Robot added the comment: New changeset 356ed025dbae by Serhiy Storchaka in branch '3.3': Issues #23363, #23364, #23365, #23366: Fixed itertools overflow tests. https://hg.python.org/cpython/rev/356ed025dbae New changeset 98c720c3e061 by Serhiy Storchaka in branch '3.4': Issues #23363, #2

[issue23366] integer overflow in itertools.combinations

Benjamin Peterson added the comment: lgtm -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue23366] integer overflow in itertools.combinations

Serhiy Storchaka added the comment: And with this patch an OverflowError in tests should be replaced with (OverflowError, MemoryError). Updated patch also fixes other bugs in itertools tests. -- resolution: fixed -> stage: resolved -> patch review Added file: http://bugs.python.org/fi

[issue23366] integer overflow in itertools.combinations

Serhiy Storchaka added the comment: This commit (and three other) causes compiler warnings: ./Modules/itertoolsmodule.c: In function ‘product_new’: ./Modules/itertoolsmodule.c:2025:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (repeat > PY_

[issue23366] integer overflow in itertools.combinations

Roundup Robot added the comment: New changeset 014886dae5c4 by Benjamin Peterson in branch '3.3': detect overflow in combinations (closes #23366) https://hg.python.org/cpython/rev/014886dae5c4 New changeset 2f73de7ffcf5 by Benjamin Peterson in branch '3.4': merge 3.3 (#23366) https://hg.python.o

[issue23366] integer overflow in itertools.combinations

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue23366] integer overflow in itertools.combinations

New submission from paul: # Bug # --- # # static PyObject * # combinations_new(PyTypeObject *type, PyObject *args, PyObject *kwds) # { # ... # # 1 indices = PyMem_Malloc(r * sizeof(Py_ssize_t)); # ... # # for (i=0 ; i0, so we write well beyond the buffer's end # # Crash # -