[issue23358] BaseServer missing from socketserver.__all__

Roundup Robot added the comment: New changeset e614ff664877 by Berker Peksag in branch '3.4': Issue #23358: Add missing BaseServer entry to socketserver.__all__. https://hg.python.org/cpython/rev/e614ff664877 New changeset 80d282505d21 by Berker Peksag in branch 'default': Issue #23358: Add miss

[issue23358] BaseServer missing from socketserver.__all__

Berker Peksag added the comment: Thanks for the patch, Martin. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue23358] BaseServer missing from socketserver.__all__

Martin Panter added the comment: New test case looks good. Checking for the underscore prefix is how I would have done it too, if I had realized it was needed :) I’m not qualified to comment on removing the run_unittest() call. -- ___ Python tracker

[issue23358] BaseServer missing from socketserver.__all__

Berker Peksag added the comment: Thanks for the patch, Martin. I got the following failure on the 3.4 branch: == FAIL: test_all (test.test_socketserver.SimpleTests) ---

[issue23358] BaseServer missing from socketserver.__all__

New submission from Martin Panter: This patch adds BaseServer to __all__. It also adds a test case that should automatically fail if someone defines a new function or class in the “socketserver” module and does not update __all__. -- components: Library (Lib) files: socketserver-all.pa