[issue23154] MSVC 2013 Express needlessly rebuilds code

2015-01-22 Thread Steve Dower
Steve Dower added the comment: That change modified pythoncore, so I'd expect to see most projects rebuild. Especially under Release, where we don't have some of the build optimizations enabled (because they hurt runtime performance). -- ___ Python

[issue23154] MSVC 2013 Express needlessly rebuilds code

2015-01-21 Thread Mark Lawrence
Mark Lawrence added the comment: I've noticed a similar problem this morning with 5 modules rebuilt under Debug but 29 under Release. I believe the change that triggered me spotting it is this fb8a093db8b1 Issue #23095. Do we need a new issue for this? -- ___

[issue23154] MSVC 2013 Express needlessly rebuilds code

2015-01-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset d53506fe31e1 by Zachary Ware in branch 'default': Closes #23154: Fix unnecessary recompilation of OpenSSL on Windows https://hg.python.org/cpython/rev/d53506fe31e1 -- nosy: +python-dev resolution: -> fixed stage: -> resolved status: open -

[issue23154] MSVC 2013 Express needlessly rebuilds code

2015-01-03 Thread Zachary Ware
Zachary Ware added the comment: Our original explanation accounts for the 31 projects "rebuilding". I'll get the patch committed later tonight (hopefully). -- ___ Python tracker

[issue23154] MSVC 2013 Express needlessly rebuilds code

2015-01-03 Thread Steve Dower
Steve Dower added the comment: Ah, I forgot to put Configuration in there. That patch is fine. If it's only the OpenSSL projects doing this, that shouldn't cause 31 projects to rebuild (4 at most I'd have though), but it probably will cause more rebuilds than necessary. -- __

[issue23154] MSVC 2013 Express needlessly rebuilds code

2015-01-03 Thread Zachary Ware
Zachary Ware added the comment: On testing, you are correct, Mark. Sorry for the premature close. How does this patch look to you, Steve? -- assignee: -> zach.ware keywords: +patch resolution: not a bug -> stage: resolved -> status: closed -> open type: -> behavior Added file: http

[issue23154] MSVC 2013 Express needlessly rebuilds code

2015-01-03 Thread Mark Lawrence
Changes by Mark Lawrence : Added file: http://bugs.python.org/file37588/CMDdebugbuildoutput.log ___ Python tracker ___ ___ Python-bugs-list ma

[issue23154] MSVC 2013 Express needlessly rebuilds code

2015-01-03 Thread Mark Lawrence
Mark Lawrence added the comment: I build from the GUI. I've just tried the Release build, it very quickly rebuilt the first four items and said the rest were up to date. I switched to Debug and got the output in the attached file. This is what I meant earlier by the effect toggling between

[issue23154] MSVC 2013 Express needlessly rebuilds code

2015-01-03 Thread Jeremy Kloth
Changes by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue23154] MSVC 2013 Express needlessly rebuilds code

2015-01-03 Thread Zachary Ware
Zachary Ware added the comment: Hmmm, what are sections 3 and 4? Are you building from the VS GUI or Command Prompt? >From Command Prompt in a clean checkout, running PCbuild\build.bat -d -e (debug build) should take several minutes. The same again should be quick, and then just "PCbuild\build.b

[issue23154] MSVC 2013 Express needlessly rebuilds code

2015-01-03 Thread Mark Lawrence
Mark Lawrence added the comment: Then we're not talking about the same thing. Maybe my setup is wrong, but a load of files were recompiled (from memory I think from sections 3 and 4 of the Release build) so it took minutes rather than fractions of a second. -- ___

[issue23154] MSVC 2013 Express needlessly rebuilds code

2015-01-03 Thread Zachary Ware
Zachary Ware added the comment: To clarify a bit, there's very little re-compiling, but everything that references the pythoncore project (every extension) is re-linked. There's no way around that short of not including the hg revision (which I won't accept :), but the re-linking only takes a

[issue23154] MSVC 2013 Express needlessly rebuilds code

2015-01-03 Thread Steve Dower
Steve Dower added the comment: This is because the hg id result has changed and we embed that into python35.dll. You'll see the same thing after an edit too (when the revision has + added). -- ___ Python tracker

[issue23154] MSVC 2013 Express needlessly rebuilds code

2015-01-03 Thread Mark Lawrence
New submission from Mark Lawrence: I've suspected that this is the case for some time but I've confirmed it this morning. I ran synchronize and the highest revision was 94004 "Changes %s to %ls in wprintf in launcher.c for C99 compatibility." As expected MSVC rebuilt the launcher. Later I r