[issue23151] _loggerClass is initialized twice

2015-01-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8bfe230db0bc by Vinay Sajip in branch 'default': Closes #23151: Removed unnecessary initialization. https://hg.python.org/cpython/rev/8bfe230db0bc -- nosy: +python-dev resolution: -> fixed stage: -> resolved status: open -> closed ___

[issue23151] _loggerClass is initialized twice

2015-01-02 Thread Vinay Sajip
Vinay Sajip added the comment: Okay, I'll see if I can make it clearer. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue23151] _loggerClass is initialized twice

2015-01-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Is this causing some actual problem? No, this does not cause actual problem except that it looks confusing. So really this decreased readability to me. -- ___ Python tracker

[issue23151] _loggerClass is initialized twice

2015-01-02 Thread Vinay Sajip
Vinay Sajip added the comment: The code in Manager.getLogger() allows an overriding logger class for that manager instance only - if it's not set (which is the default), it uses the module global _loggerClass. The lines rv = (self.loggerClass or _loggerClass)(name) indicate this. The module

[issue23151] _loggerClass is initialized twice

2015-01-02 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: In Lib/logging/__init__.py at line 1089 _loggerClass is initialized to None. The code in Manager.getLogger() expects that it can be None. But at line 1549 _loggerClass is initialized to Logger. And there is no official way to set it to None. Looks as eithe