[issue2304] subprocess under windows fails to quote properly when shell=True

Weeble added the comment: Is there any way to write code that's safe with or without this fix? If I have code that currently does this: subprocess.check_call('""c:\some path with spaces" arg1 arg2 "a quoted arg""', shell=True) ...will it break when running on a version of Python with this fi

[issue2304] subprocess under windows fails to quote properly when shell=True

Tim Golden added the comment: ReComitted as r83947, r83956, r83957 and this time the buildbots look happy. (At least as regards this change). -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue2304] subprocess under windows fails to quote properly when shell=True

Benjamin Peterson added the comment: Reverted because of test-breakage on unixes. -- nosy: +benjamin.peterson resolution: fixed -> status: closed -> open ___ Python tracker ___

[issue2304] subprocess under windows fails to quote properly when shell=True

Tim Golden added the comment: Committed as r83830, r83831, r83832 -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue2304] subprocess under windows fails to quote properly when shell=True

Changes by Tim Golden : -- assignee: -> tim.golden components: +Windows ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue2304] subprocess under windows fails to quote properly when shell=True

Changes by David Stanek : -- nosy: +dstanek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue2304] subprocess under windows fails to quote properly when shell=True

Mark Lawrence added the comment: @Tim: @Gabriel: test_subprocess has changed a lot since the patch was done. If one of you could provide a new patch for 2.7 and py3k I'll test it, thanks. -- nosy: +BreamoreBoy versions: -Python 2.6 ___ Python trac

[issue2304] subprocess under windows fails to quote properly when shell=True

Gabriel Genellina added the comment: An up-to-date patch; same contents, but this one can be cleanly applied to trunk (as of r76294) -- versions: +Python 2.7, Python 3.1, Python 3.2 Added file: http://bugs.python.org/file15340/subprocess.diff ___ Py

[issue2304] subprocess under windows fails to quote properly when shell=True

Changes by David Fraser : -- nosy: +davidfraser ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue2304] subprocess under windows fails to quote properly when shell=True

Changes by Tennessee Leeuwenburg : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue2304] subprocess under windows fails to quote properly when shell=True

Tim Golden <[EMAIL PROTECTED]> added the comment: Updated patch against r61514. Test code now PEP8-compliant (I hope). New tests cover spaces in command and parameter with and without shell=True, both as simple command string and as list of command/args. Added file: http://bugs.python.org/file97

[issue2304] subprocess under windows fails to quote properly when shell=True

Tim Golden <[EMAIL PROTECTED]> added the comment: Gabriel Genellina wrote: > Gabriel Genellina <[EMAIL PROTECTED]> added the comment: > > You aren't testing the modified code, the Popen call should say > shell=True. > > I think that a more PEP8-compliant style would be nice (removing the > sp

[issue2304] subprocess under windows fails to quote properly when shell=True

Gabriel Genellina <[EMAIL PROTECTED]> added the comment: You aren't testing the modified code, the Popen call should say shell=True. I think that a more PEP8-compliant style would be nice (removing the spaces after open and read, and using consistent indentation) -- nosy: +gagenellina

[issue2304] subprocess under windows fails to quote properly when shell=True

Changes by Tim Golden <[EMAIL PROTECTED]>: -- title: subprocess under windows fails to quote properly under Windows when shell=True -> subprocess under windows fails to quote properly when shell=True __ Tracker <[EMAIL PROTECTED]>