[issue22915] sax.parser cannot get xml data from a subprocess pipe

Jocelyn added the comment: Ok, I understand your tests now. Thanks for the fixes ! -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue22915] sax.parser cannot get xml data from a subprocess pipe

Serhiy Storchaka added the comment: Jocelyn, in both cases the argument of parse() is a file object with integer name. Tests use one of simplest way to create such object. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed _

[issue22915] sax.parser cannot get xml data from a subprocess pipe

Roundup Robot added the comment: New changeset 27ae1a476ef7 by Serhiy Storchaka in branch '3.4': Issue #22915: SAX parser now supports files opened with file descriptor or https://hg.python.org/cpython/rev/27ae1a476ef7 New changeset ce9881eecfb4 by Serhiy Storchaka in branch 'default': Issue #22

[issue22915] sax.parser cannot get xml data from a subprocess pipe

Jocelyn added the comment: The only explicit documentation I found on SystemId is from the java specification (it is my understanding that python sax implementation is adapted from Java one): http://www.saxproject.org/apidoc/org/xml/sax/InputSource.html#setSystemId%28java.lang.String%29 The do

[issue22915] sax.parser cannot get xml data from a subprocess pipe

R. David Murray added the comment: Serhiy's patch looks correct to me. Given that if the source doesn't have a name attribute it is simply not set in the existing code, this change should be "safe" (backward compatible). Elsewhere the possibility was raised of converting the int to a string

[issue22915] sax.parser cannot get xml data from a subprocess pipe

Serhiy Storchaka added the comment: This bug should be fixed in other place. Here is a patch. -- assignee: -> serhiy.storchaka nosy: +christian.heimes, serhiy.storchaka stage: needs patch -> patch review Added file: http://bugs.python.org/file37252/sax_non_str_file_name.patch _

[issue22915] sax.parser cannot get xml data from a subprocess pipe

R. David Murray added the comment: Has anyone investigated what exactly sax uses SystemId/SetBase *for*? I think think we need that info in order to decide what to do, and I'm not familiar with sax. -- ___ Python tracker

[issue22915] sax.parser cannot get xml data from a subprocess pipe

Jocelyn added the comment: Forgot to attach the testcase when opening the bug. -- Added file: http://bugs.python.org/file37250/toto.py ___ Python tracker ___

[issue22915] sax.parser cannot get xml data from a subprocess pipe

Jocelyn added the comment: Here is a patch to add a test to test_sax.py. I'm not sure on the fix. Is the following one a correct one ? def prepareParser(self, source): if source.getSystemId() is not None: -self._parser.SetBase(source.getSystemId()) +self._p

[issue22915] sax.parser cannot get xml data from a subprocess pipe

Changes by Avneesh Chadha : -- nosy: +Avneesh.Chadha ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue22915] sax.parser cannot get xml data from a subprocess pipe

Changes by Serhiy Storchaka : -- stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue22915] sax.parser cannot get xml data from a subprocess pipe

R. David Murray added the comment: I've looked at the sax code, and this does indeed have the same root cause: in python2 a dummy string was used for the 'name' attribute of io objects that are based on file descriptors, whereas in python3 the name is the integer value of the file descriptor.

[issue22915] sax.parser cannot get xml data from a subprocess pipe

Changes by R. David Murray : -- versions: +Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue22915] sax.parser cannot get xml data from a subprocess pipe

R. David Murray added the comment: My guess is that this is similar to issue 21044. -- nosy: +r.david.murray ___ Python tracker ___ __

[issue22915] sax.parser cannot get xml data from a subprocess pipe

New submission from Jocelyn: With the attached code, and an xml file, I got the following error with python 3.4.2: $ cat toto.xml $ python3.4 toto.py Traceback (most recent call last): File "toto.py", line 10, in parse(proc.stdout, ContentHandler()) File "/usr/lib/python3.4/xml/sa