[issue22908] ZipExtFile in zipfile can be seekable

Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> commit review status: open -> closed versions: +Python 3.7 -Python 3.5 ___ Python tracker ___ __

[issue22908] ZipExtFile in zipfile can be seekable

Gregory P. Smith added the comment: New changeset 066df4fd454d6ff9be66e80b2a65995b10af174f by Gregory P. Smith (John Jolly) in branch 'master': bpo-22908: Add seek and tell functionality to ZipExtFile (GH-4966) https://github.com/python/cpython/commit/066df4fd454d6ff9be66e80b2a65995b10af174f

[issue22908] ZipExtFile in zipfile can be seekable

Change by Gregory P. Smith : -- assignee: serhiy.storchaka -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker ___ ___ Pytho

[issue22908] ZipExtFile in zipfile can be seekable

John Jolly added the comment: Please be gentle, this is my first submission to python. The use case for me was a recursive zip-within-a-zip situation. I wanted to allow the creation of a zipfile.ZipFile from an existing zipfile.ZipExtFile, but the lack of seek prevented this. I simply treate

[issue22908] ZipExtFile in zipfile can be seekable

Change by Roundup Robot : -- pull_requests: +4858 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mail

[issue22908] ZipExtFile in zipfile can be seekable

Jürgen A. Erhard added the comment: To add to this (without looking at the patch): I just to my astonishment learned that a ZipExtFile doesn't even support tell(). I can understand the seek being nontrivial... but the tell? It's a bytestream, and there is (isn't there?) a clear definition of

[issue22908] ZipExtFile in zipfile can be seekable

Daniel Kessel added the comment: It would be great to have the ZipFileExt class seekable. This would help in implementing features in other projects. For example, pydicom would gain the ability to read from ZIP files, as mentioned in https://github.com/darcymason/pydicom/issues/219 --

[issue22908] ZipExtFile in zipfile can be seekable

Serhiy Storchaka added the comment: Actually TarFile already works with non-seekable streams. Use TarFile.open() with mode='r|*' or like. On other hand I'm not against the make non-compressed ZipExtFile seekable. It can be helpful in case when ZIP file is used just as a container for other fi

[issue22908] ZipExtFile in zipfile can be seekable

Serhiy Storchaka added the comment: I'm -1 on adding the seek method with linear complexity. This looks as attractive nonsense to me. It would be better just make TarFile working with non-seekable streams. -- nosy: +serhiy.storchaka ___ Python track

[issue22908] ZipExtFile in zipfile can be seekable

New submission from Iridium Yang: The ZipExtFile class in zipfile module does not provide a seek method like GzipFile. As a result, it is hard to manipulate files without extract all the content. For example, a very large tar file compressed with zip. The TarFile module can operate on file obj