[issue22834] Unexpected FileNotFoundError when current directory is removed

Changes by Christopher Meng : -- nosy: +Christopher Meng ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue22834] Unexpected FileNotFoundError when current directory is removed

Brett Cannon added the comment: Thanks for catches the mistakes, guys! -- status: open -> closed ___ Python tracker ___ ___ Python-bug

[issue22834] Unexpected FileNotFoundError when current directory is removed

Roundup Robot added the comment: New changeset 38c503c2c066 by Brett Cannon in branch 'default': Issue #22834: Drop a redundant comment and use errno instead of an https://hg.python.org/cpython/rev/38c503c2c066 -- ___ Python tracker

[issue22834] Unexpected FileNotFoundError when current directory is removed

Changes by Brett Cannon : -- status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue22834] Unexpected FileNotFoundError when current directory is removed

Martin Panter added the comment: +1 to EINVAL, also the bug reference comment is redundant with the one at the top of the test case :) -- ___ Python tracker ___

[issue22834] Unexpected FileNotFoundError when current directory is removed

Serhiy Storchaka added the comment: May be better use errno.EINVAL? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue22834] Unexpected FileNotFoundError when current directory is removed

Brett Cannon added the comment: Thanks for the suggestion, Martin. Went with a variant of what you proposed. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker __

[issue22834] Unexpected FileNotFoundError when current directory is removed

Roundup Robot added the comment: New changeset f4f2096ab6f8 by Brett Cannon in branch 'default': Issue #22834: Fix a failing test under Solaris due to the platform not https://hg.python.org/cpython/rev/f4f2096ab6f8 -- ___ Python tracker

[issue22834] Unexpected FileNotFoundError when current directory is removed

Martin Panter added the comment: I don’t have a Solaris to test this, but maybe changing the first half of the test to the following would work: dir = tempfile.TemporaryDirectory() self.addCleanup(dir.cleanup) # In case removal after chdir() fails self.addCleanup(os.chdir, os.getcwd()) os.chdi

[issue22834] Unexpected FileNotFoundError when current directory is removed

Serhiy Storchaka added the comment: Tests failed on Solaris: http://buildbot.python.org/all/builders/AMD64%20Solaris%2011%20%5BSB%5D%203.x/builds/3895/steps/test/logs/stdio == ERROR: test_deleted_cwd (test.test_importlib.import

[issue22834] Unexpected FileNotFoundError when current directory is removed

Roundup Robot added the comment: New changeset d065e6474b67 by Zachary Ware in branch 'default': Issue #22834: cwd can't not exist on Windows, skip the test https://hg.python.org/cpython/rev/d065e6474b67 -- ___ Python tracker

[issue22834] Unexpected FileNotFoundError when current directory is removed

Brett Cannon added the comment: Along with fixing this I also updated the import reference to mention how the current working directory is handled. Thanks to Martin for the report and everyone for their input! -- resolution: -> fixed stage: -> resolved status: open -> closed versions

[issue22834] Unexpected FileNotFoundError when current directory is removed

Roundup Robot added the comment: New changeset 8558fff73032 by Brett Cannon in branch 'default': Issue #22834: Have import suppress FileNotFoundError when the current https://hg.python.org/cpython/rev/8558fff73032 -- nosy: +python-dev ___ Python track

[issue22834] Unexpected FileNotFoundError when current directory is removed

Brett Cannon added the comment: I have a patch to silence the exception and I'm running the test suite now. I'm planning to keep this to a 3.5 fix and not changing the semantics in Python 3.4 as the fix is a little different from the standard "directory in sys.path is invalid" since '' is dyna

[issue22834] Unexpected FileNotFoundError when current directory is removed

Martin Panter added the comment: The only time I see a warning would be useful is if you intended to override a standard module with a module of the same name in the current directory. In all other cases I think it would be better to either generate an ImportError if the module is not found, o

[issue22834] Unexpected FileNotFoundError when current directory is removed

Terry J. Reedy added the comment: How about issue a verbose warning for possible debugging and continue for robustness? -- nosy: +terry.reedy ___ Python tracker ___

[issue22834] Unexpected FileNotFoundError when current directory is removed

R. David Murray added the comment: Well, once I've launched a program, regardless of whether or not I expected some stuff to come from the CWD, I generally don't think about whether or not the CWD might go away, and in a complex setup it would most likely be getting deleted by some other proce

[issue22834] Unexpected FileNotFoundError when current directory is removed

Brett Cannon added the comment: So it isn't about importlib not handling missing directories on sys.path directly, it has to do with the fact that os.getcwd() raises FileNotFoundError when CWD is no longer valid and that is in a fundamental part of importlib that isn't worrying about non-exist

[issue22834] Unexpected FileNotFoundError when current directory is removed

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue22834] Unexpected FileNotFoundError when current directory is removed

Changes by Brett Cannon : -- assignee: -> brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue22834] Unexpected FileNotFoundError when current directory is removed

R. David Murray added the comment: Looks like importlib doesn't handle the case of a directory on the path being deleted? If so, I'm surprised this hasn't been reported before. -- nosy: +brett.cannon, eric.snow, r.david.murray ___ Python tracker

[issue22834] Unexpected FileNotFoundError when current directory is removed

New submission from Martin Panter: I encountered this when I added a unit test case that invoked os.chdir() with a temporary directory on Linux. After the directory was removed, some of the subsequent test cases failed, although I don’t think they should depend on a particular CWD. I suspect