[issue2279] distutils sdist add_defaults does not add data_files

Changes by Éric Araujo : -- resolution: accepted -> fixed stage: -> committed/rejected ___ Python tracker ___ ___ Python-bugs-list mai

[issue2279] distutils sdist add_defaults does not add data_files

Tarek Ziadé added the comment: > Opened #5300 and #5302 for the mentioned issues. ok thanks > Btw in your patch, I believe `os.path.join(dirname, f)` should be > replaced by `f` alone; `dirname` refers to the dir under the > installation directory, not the source. Right, thanks George. I'v a

[issue2279] distutils sdist add_defaults does not add data_files

George Sakkis added the comment: Opened #5300 and #5302 for the mentioned issues. Btw in your patch, I believe `os.path.join(dirname, f)` should be replaced by `f` alone; `dirname` refers to the dir under the installation directory, not the source. ___ Pyth

[issue2279] distutils sdist add_defaults does not add data_files

Tarek Ziadé added the comment: 2009/2/17 George Sakkis : >> Maybe that could be a new feature ? > > That would be nice, especially if we want to reimplement MANIFEST.in as > setup() option at some point. My current implementation doesn't extend > the API, so there's no way to specify a subset of

[issue2279] distutils sdist add_defaults does not add data_files

Tarek Ziadé added the comment: added in r69710. Thx ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue2279] distutils sdist add_defaults does not add data_files

George Sakkis added the comment: > done in r69692 and r69696. Great, thanks. The data_files part though seems incorrect; for one thing each item in data_files can be either a (dir,files) tuple or a plain string, and for two 'dir' is the output (installation) directory, not the root of 'files'.

[issue2279] distutils sdist add_defaults does not add data_files

George Sakkis added the comment: > > FWIW I wrote a module that overrides the default build_py and sdist > > commands with versions that allow specifying package_data recursively > > Maybe that could be a new feature ? That would be nice, especially if we want to reimplement MANIFEST.in as se

[issue2279] distutils sdist add_defaults does not add data_files

Changes by Tarek Ziadé : -- versions: -Python 2.6, Python 3.0 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue2279] distutils sdist add_defaults does not add data_files

Tarek Ziadé added the comment: done in r69692 and r69696. -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailin

[issue2279] distutils sdist add_defaults does not add data_files

Tarek Ziadé added the comment: Ok I have finished the patch, I'll commit it during the week > FWIW I wrote a module that overrides the default build_py and sdist > commands with versions that allow specifying package_data recursively Maybe that could be a new feature ? > (while preserving f

[issue2279] distutils sdist add_defaults does not add data_files

George Sakkis added the comment: By an equivalent option in setup() of course. I'm not against the *functionality* of MANIFEST.in but on that (a) it's a second file you have to remember to write and maintain in addition to setup.py (b) has its own ad-hoc syntax instead of python and (c) overlaps

[issue2279] distutils sdist add_defaults does not add data_files

Changes by Tarek Ziadé : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bu

[issue2279] distutils sdist add_defaults does not add data_files

Tarek Ziadé added the comment: Right, but if MANIFEST.in is removed, I can see cases where you would need the same kind of mini-syntax in your setup.py. For instance, how would you tell sdist to recursively add files located in a directory (like the current recursive-include feature of MANIFEST

[issue2279] distutils sdist add_defaults does not add data_files

Tarek Ziadé added the comment: Right, but if MANIFEST.in is removed, I can see cases where you would need the same kind of mini-syntax in your setup.py. For instance, how would you tell sdist to recursively add files located in a directory (like the current recursive-include feature of MANIFEST

[issue2279] distutils sdist add_defaults does not add data_files

George Sakkis added the comment: I didn't mean to imply that automagic discovery based on external version control software is better than MANIFEST.in; I favor explicitness here as well. It's just that this information can (and often has to) be duplicated in setup.py as 'package_data' or 'data_f

[issue2279] distutils sdist add_defaults does not add data_files

Tarek Ziadé added the comment: I'll change add_defaults() so it includes package_data. I don't think though, that MANIFEST.in is an ugly hack. Imho the best practice is an explicit MANIFEST.in (and not use the .svn browsing setuptools do) -- priority: -> high resolution: -> accepted

[issue2279] distutils sdist add_defaults does not add data_files

George Sakkis added the comment: Agreed; package_data are also ignored by sdist. Unfortunately, neither setuptools seems to work as expected on sdist but at least bdist_egg does. MANIFEST.in is an ugly hack and should be deprecated; you shouldn't have to repeat yourself in two files. -

[issue2279] distutils sdist add_defaults does not add data_files

Changes by Tarek Ziadé : -- assignee: -> tarek nosy: +tarek versions: +Python 2.7, Python 3.1 -Python 2.4, Python 2.5 ___ Python tracker ___ _

[issue2279] distutils sdist add_defaults does not add data_files

New submission from David Ripton <[EMAIL PROTECTED]>: distutils.sdist.add_defaults adds the Python modules and scripts and C extensions found in setup.py to the MANIFEST. It does *not* add data_files mentioned in setup.py to the MANIFEST. This is non-orthogonal and confusing, because it means t