[issue22558] Missing doc links to source code for Python-coded modules.

Yoni Lavi added the comment: Created issue 27304 and uploaded a patch. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue22558] Missing doc links to source code for Python-coded modules.

Terry J. Reedy added the comment: Yes, new issue, make me nosy, assign to me if allowed, upload patch. Start with "This is a follow to #22558." -- ___ Python tracker ___ ___

[issue22558] Missing doc links to source code for Python-coded modules.

Yoni Lavi added the comment: Thank you Terry, Nathan and David for your work on this. Sorry about the whitespace issue, I indeed forgot to run patchcheck when I prepared the 3rd patch. Tery, would you like me to prepare a patch for the follow-on you suggested? If so, given that this one is now

[issue22558] Missing doc links to source code for Python-coded modules.

Terry J. Reedy added the comment: I committed the excellent patch. It should appear in the upcoming 3.5 and 3.6 releases, and within a day online. Thanks to both package author and also to reviewers. I would like to see more patches like this. I reverted the deletion of version added in moc

[issue22558] Missing doc links to source code for Python-coded modules.

Roundup Robot added the comment: New changeset 222c1d461aa8 by Terry Jan Reedy in branch '3.5': Issue #22558: Add remaining doc links to source code for Python-coded modules. https://hg.python.org/cpython/rev/222c1d461aa8 New changeset 2a01d7a488e9 by Terry Jan Reedy in branch 'default': Merge I

[issue22558] Missing doc links to source code for Python-coded modules.

Changes by Terry J. Reedy : -- assignee: docs@python -> terry.reedy stage: patch review -> commit review ___ Python tracker ___ ___ Py

[issue22558] Missing doc links to source code for Python-coded modules.

Nathan Harold added the comment: I went over the sections I above called "Other/Smaller details" as addressed in mywork3.patch. I think they look fine. The patch applies seamlessly to both 3.5 and 3.6. For reference, since I noted them when I reviewed mywork2.patch last week, here are the p

[issue22558] Missing doc links to source code for Python-coded modules.

Yoni Lavi added the comment: Thank you very much for the detailed review, Nathan. Attached is a new patch that resolves the merge issues, and some of the other issues you mentioned. Concerning the index reference in marshal.rst , ah, yes, I missed that it only related to a single paragraph. I

[issue22558] Missing doc links to source code for Python-coded modules.

Terry J. Reedy added the comment: Great report. It appears that the remaining questions are subjective decisions for a core developer: what is the best link, if any, for a package; should the link also be last thing in the section. -- ___ Python tr

[issue22558] Missing doc links to source code for Python-coded modules.

Nathan Harold added the comment: I went through all the diffs in Rietveld, checking it against msg228576 as I went. There were (naturally) more source links added than there are in that list from 2014, and there were also many more files with slight header reorganizations for consistency. An

[issue22558] Missing doc links to source code for Python-coded modules.

Terry J. Reedy added the comment: For me, the issue is willingness, not permission ;-). Reviewing a patch includes somehow indicating changes needed to apply it 'today', and a revised patch is the best way. Please say whether the header changes are in 3.6 only (in which case a separate 3.5 p

[issue22558] Missing doc links to source code for Python-coded modules.

Nathan Harold added the comment: I'll give this a go, per Terry's instructions in msg266846. I've noticed up front that, due to other changes near the headers of a couple of files (specifically fcntl.rst and termios.rst), the patch doesn't apply cleanly anymore. Is it permissible for me to fi

[issue22558] Missing doc links to source code for Python-coded modules.

Changes by Nathan Harold : -- nosy: +nharold ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue22558] Missing doc links to source code for Python-coded modules.

Yoni Lavi added the comment: Ah, thanks for the explanation. I think in this case we're ok too. I linked io.rst to Lib/io.py, which relies on the C version. And in the case of decimal.rst, it was already linked to Lib/decimal.py which very explicitly attempts to load the C version and falls bac

[issue22558] Missing doc links to source code for Python-coded modules.

R. David Murray added the comment: Yes, those should be OK. I was thinking of _pyio and _pydecimal, but I don't know if you are linking to those. -- ___ Python tracker ___

[issue22558] Missing doc links to source code for Python-coded modules.

Yoni Lavi added the comment: Thank you for looking at this. David, concerning modules that have multiple sources, are you referring to modules such as `stat` and `heapq`? In these, it's the Python source that tries to import the C module if it's available, so I'd consider it ok to leave just a

[issue22558] Missing doc links to source code for Python-coded modules.

Terry J. Reedy added the comment: If someone does a full review (looks at each diff in Rietveld to see if it matches the intended format -- see Yoni's 4-19 message, with :source:`Lib/mod.py` (lib2to3 is an exception) following **Source code:** -- and then downloads patch, applies, builds new htm

[issue22558] Missing doc links to source code for Python-coded modules.

R. David Murray added the comment: I meant full review, not file review. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue22558] Missing doc links to source code for Python-coded modules.

R. David Murray added the comment: You mean someone doing a file review at the sprints? I can add it to the list. No guarantees about it getting committed at the sprints, though. If we are linking to the python version of modules that have both python and C versions, IMO the existence of the

[issue22558] Missing doc links to source code for Python-coded modules.

Terry J. Reedy added the comment: [David, could this be a sprint issue?] Here is the difference between python and C coded modules. The x.y docs are for all implementations of x.y. The python-coded modules are intended for use by all implementations, perhaps with minor modifications. In an