[issue22518] integer overflow in encoding unicode

Changes by Benjamin Peterson : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue22518] integer overflow in encoding unicode

Serhiy Storchaka added the comment: Integer overflow errors were fixed in 4 error handlers: surrogatepass, backslashreplace, namereplace, and xmlcharrefreplace. Is is hard to write general robust tests. In worst cases they requires more than sys.maxsize or even sys.maxsize*2 memory and for sur

[issue22518] integer overflow in encoding unicode

Benjamin Peterson added the comment: I wouldn't object if you had a patch. -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Pyth

[issue22518] integer overflow in encoding unicode

Serhiy Storchaka added the comment: Do you want to add a bigmem test or close this issue Benjamin? -- ___ Python tracker ___ ___ Pytho

[issue22518] integer overflow in encoding unicode

Serhiy Storchaka added the comment: Sorry for noise, these changes are related to issue22470. -- ___ Python tracker ___ ___ Python-bug

[issue22518] integer overflow in encoding unicode

Roundup Robot added the comment: New changeset 51317c9786f5 by Serhiy Storchaka in branch '3.3': Issue #22518: Fixed integer overflow issues in "backslashreplace", https://hg.python.org/cpython/rev/51317c9786f5 -- ___ Python tracker

[issue22518] integer overflow in encoding unicode

Roundup Robot added the comment: New changeset d1be1f355f59 by Serhiy Storchaka in branch '2.7': Fixed compilation error introduced in 3f7519f633ed (issue #22518). https://hg.python.org/cpython/rev/d1be1f355f59 -- ___ Python tracker

[issue22518] integer overflow in encoding unicode

Roundup Robot added the comment: New changeset 3f7519f633ed by Serhiy Storchaka in branch '2.7': Issue #22518: Fixed integer overflow issues in "backslashreplace" and https://hg.python.org/cpython/rev/3f7519f633ed New changeset ec9b7fd246b6 by Serhiy Storchaka in branch '3.4': Issue #22518: Fixe

[issue22518] integer overflow in encoding unicode

Serhiy Storchaka added the comment: > Ooops, wrong issue, the test is : ("\u" * (2**29)).encode("latin1", > errors="xmlcharrefreplace"). ("\u" * (sys.maxsize//8+1)).encode("latin1", errors="xmlcharrefreplace") or ("\xff" * (sys.maxsize//6+1)).encode("ascii", errors="xmlcharrefreplace")

[issue22518] integer overflow in encoding unicode

Georg Brandl added the comment: Benjamin, could you make a patch for 3.2 as well? -- nosy: +georg.brandl ___ Python tracker ___ ___ Py

[issue22518] integer overflow in encoding unicode

Changes by STINNER Victor : -- type: crash -> security ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue22518] integer overflow in encoding unicode

STINNER Victor added the comment: > This is correct. This check prevents overflow. Oh, I didn't understand that "requiredsize = 2*outsize;" is only used for performances, to overallocate the buffer. So I agree that it's fine to not overallocate if it would overflow. -- __

[issue22518] integer overflow in encoding unicode

Serhiy Storchaka added the comment: > I'm not sure that this change is correct. Why not raising an exception on > overflow? This is correct. This check prevents overflow. -- ___ Python tracker

[issue22518] integer overflow in encoding unicode

Changes by STINNER Victor : -- resolution: fixed -> status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue22518] integer overflow in encoding unicode

STINNER Victor added the comment: > It would be nice to add a bigmem test to check that repr('\x00'*(2**30+1)) > doesn't crash anymore. Ooops, wrong issue, the test is : ("\u" * (2**29)).encode("latin1", errors="xmlcharrefreplace"). -- ___ Pyth

[issue22518] integer overflow in encoding unicode

STINNER Victor added the comment: It would be nice to add a bigmem test to check that repr('\x00'*(2**30+1)) doesn't crash anymore. -- ___ Python tracker ___ ___

[issue22518] integer overflow in encoding unicode

STINNER Victor added the comment: > New changeset f86fde20e9ce by Benjamin Peterson in branch 'default': > merge 3.4 (closes #22518) > https://hg.python.org/cpython/rev/f86fde20e9ce This changeset added " other". It looks like you commited a conflict. -if (requiredsize<2*outsize) +

[issue22518] integer overflow in encoding unicode

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue22518] integer overflow in encoding unicode

Roundup Robot added the comment: New changeset b2e68274aa8e by Benjamin Peterson in branch '2.7': cleanup overflowing handling in unicode_decode_call_errorhandler and unicode_encode_ucs1 (closes #22518) https://hg.python.org/cpython/rev/b2e68274aa8e New changeset 3b7e93249700 by Benjamin Peters

[issue22518] integer overflow in encoding unicode

Changes by Benjamin Peterson : -- versions: +Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue22518] integer overflow in encoding unicode

Changes by Benjamin Peterson : -- versions: +Python 2.7, Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue22518] integer overflow in encoding unicode

Serhiy Storchaka added the comment: Looks very similar to issue22470. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bug

[issue22518] integer overflow in encoding unicode

New submission from paul: # static PyObject * # unicode_encode_ucs1(PyObject *unicode, # const char *errors, # unsigned int limit) # { # ... # while (pos < size) { # ... # case 4: /* xmlcharrefreplace */ # /* determ