[issue2250] rlcompleter raises Exception on bad input

Georg Brandl <[EMAIL PROTECTED]> added the comment: Committed code and doc patches as r63094. Thanks! -- nosy: +georg.brandl resolution: -> accepted status: open -> closed __ Tracker <[EMAIL PROTECTED]>

[issue2250] rlcompleter raises Exception on bad input

Changes by Lorenz Quack <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10054/rlcompleter.rst.diff __ Tracker <[EMAIL PROTECTED]> __ ___ P

[issue2250] rlcompleter raises Exception on bad input

Lorenz Quack <[EMAIL PROTECTED]> added the comment: In the last patch I used the wrong ticks. I hope it's fine like this. Added file: http://bugs.python.org/file10055/rlcompleter.rst.diff __ Tracker <[EMAIL PROTECTED]> _

[issue2250] rlcompleter raises Exception on bad input

Lorenz Quack <[EMAIL PROTECTED]> added the comment: I attached a patch for the docs. It now states that the rlcompleter.Completer will catch and silence all exceptions raised by evaluating the expression passed to complete() Added file: http://bugs.python.org/file10054/rlcompleter.rst.diff

[issue2250] rlcompleter raises Exception on bad input

Lorenz Quack <[EMAIL PROTECTED]> added the comment: I confirmed that the rlcompleter can raise a SyntaxError on bad input. Upon further investigation I found that a ReferenceError could also be raised. I didn't check on other Exceptions. I attached a new version of the patch where I catch all Er

[issue2250] rlcompleter raises Exception on bad input

Lorenz Quack <[EMAIL PROTECTED]> added the comment: I was thinking that the code in question could maybe also raise other exceptions. too bad I´m on vacation and can´t try this out myself. I believe the regular expression also matches something like import rlcompleter rlcompleter.Completer().co

[issue2250] rlcompleter raises Exception on bad input

Neil Schemenauer <[EMAIL PROTECTED]> added the comment: On Thu, Mar 20, 2008 at 08:49:32PM +, Sean Reifschneider wrote: > Is a straightforward patch, but I'd like NAS to comment on the change in > behavior. Probably would also need a documentation change, are you up > for doing that Lorenz?

[issue2250] rlcompleter raises Exception on bad input

Lorenz Quack <[EMAIL PROTECTED]> added the comment: I have no idea what or who NAS is but comments are always welcome :) concerning the documentation: I´ve never done it before but there is a first time for everything, right? I´m currently on vacation so I won´t look into it for at least another

[issue2250] rlcompleter raises Exception on bad input

Sean Reifschneider <[EMAIL PROTECTED]> added the comment: Is a straightforward patch, but I'd like NAS to comment on the change in behavior. Probably would also need a documentation change, are you up for doing that Lorenz? -- assignee: -> nascheme keywords: +easy nosy: +jafo, nascheme

[issue2250] rlcompleter raises Exception on bad input

New submission from Lorenz Quack: in line 130 rlcompleter calls eval on the first part (before the last dot) of the input text. if that part is not valid it will raise an exception which is likely to crash a calling application. example 1: == import rlcompleter rlcompleter.Completer().c