[issue22266] fix reliance on refcounting in tarfile.gzopen

Roundup Robot added the comment: New changeset 6f0dae921bee by Benjamin Peterson in branch '2.7': properly handle file closing in error cases (closes #22266) http://hg.python.org/cpython/rev/6f0dae921bee -- nosy: +python-dev resolution: -> fixed stage: -> resolved status: open -> close

[issue22266] fix reliance on refcounting in tarfile.gzopen

Changes by Brian Kearns : Added file: http://bugs.python.org/file36469/tarfile2.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue22266] fix reliance on refcounting in tarfile.gzopen

Changes by Brian Kearns : Removed file: http://bugs.python.org/file36468/tarfile2.patch ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue22266] fix reliance on refcounting in tarfile.gzopen

Brian Kearns added the comment: Updated to backport all the cases where 3.x handles this issue. -- Added file: http://bugs.python.org/file36468/tarfile2.patch ___ Python tracker

[issue22266] fix reliance on refcounting in tarfile.gzopen

Brian Kearns added the comment: Yes, I guess that makes sense (though this behavior is undocumented and untested...) -- Added file: http://bugs.python.org/file36462/tarfile.patch ___ Python tracker ___

[issue22266] fix reliance on refcounting in tarfile.gzopen

Changes by Brian Kearns : Removed file: http://bugs.python.org/file36456/tarfile.patch ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue22266] fix reliance on refcounting in tarfile.gzopen

Benjamin Peterson added the comment: I think technically this changes semantics, since the construction of the GzipFile is no longer in the main try-except. You should probably backport the full 3.x behavior. -- nosy: +benjamin.peterson ___ Python t

[issue22266] fix reliance on refcounting in tarfile.gzopen

Changes by Alex Gaynor : -- nosy: +alex ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue22266] fix reliance on refcounting in tarfile.gzopen

New submission from Brian Kearns: tarfile.gzopen relies on refcounting to close the fileobj when the fileobj is created during the call to gzopen (when it is not passed in). Since the fileobj is created outside of GzipFile, GzipFile does not take responsibility for closing the fileobj (so no o