[issue22226] Refactor dict result handling in Tkinter

2014-09-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Terry for your review. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ _

[issue22226] Refactor dict result handling in Tkinter

2014-09-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7b0fdc1e917a by Serhiy Storchaka in branch '2.7': Issue #6: Added private function _splitdict() in the Tkinter module. http://hg.python.org/cpython/rev/7b0fdc1e917a New changeset f89995a4ec11 by Serhiy Storchaka in branch '3.4': Issue #6: Ad

[issue22226] Refactor dict result handling in Tkinter

2014-09-06 Thread Terry J. Reedy
Terry J. Reedy added the comment: looks good to commit. -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs

[issue22226] Refactor dict result handling in Tkinter

2014-09-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Terry. Fixed style in two methods, added a summary to Treeview.set() docstring and changed returns/sets to return/set. But I disagree with other suggestions. Return value of 3-arg call is insignificant implementation detail. In any case these chang

[issue22226] Refactor dict result handling in Tkinter

2014-09-05 Thread Terry J. Reedy
Terry J. Reedy added the comment: I made two style comments, one an expansion of a previous comment. I believe all other previous comments were handled ok. -- ___ Python tracker __

[issue22226] Refactor dict result handling in Tkinter

2014-09-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: If there are no objections I'll commit the patch soon. -- ___ Python tracker ___ ___ Python-bugs-l

[issue22226] Refactor dict result handling in Tkinter

2014-08-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The patch expands and fixes buggy ttk._dict_from_tcltuple, renames and moves it to tkinter._splitdict There are differences between these functions. tkinter._splitdict calls splitlist on its argument, ttk._dict_from_tcltuple requires argument to be tuple/li

[issue22226] Refactor dict result handling in Tkinter

2014-08-20 Thread Terry J. Reedy
Terry J. Reedy added the comment: The patch expands and fixes buggy ttk._dict_from_tcltuple, renames and moves it to tkinter._splitdict, and replace 4 similar blocks of code in tkinter with calls to _splitdict. Review published. The only substantive comment is about keeping the test, in a new

[issue22226] Refactor dict result handling in Tkinter

2014-08-18 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Proposed patch refactors code which converts the result of Tcl call to Python dict. Added new private function _splitdict() which does this in more robust manner. Also this patch fixes a bug in Treeview.heading(). The heading subcommand of ttk::treeview r