[issue22182] distutils.file_util.move_file unpacks wrongly an exception

Berker Peksag added the comment: Thanks Claudiu. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ _

[issue22182] distutils.file_util.move_file unpacks wrongly an exception

Roundup Robot added the comment: New changeset a3452677a386 by Berker Peksag in branch '3.4': Issue #22182: Use e.args to unpack exceptions correctly in distutils.file_util.move_file. http://hg.python.org/cpython/rev/a3452677a386 New changeset f01413758114 by Berker Peksag in branch 'default':

[issue22182] distutils.file_util.move_file unpacks wrongly an exception

Berker Peksag added the comment: LGTM. The second test should be named different, but I will fix it myself. Thanks for the patch! -- assignee: -> berker.peksag nosy: +berker.peksag stage: patch review -> commit review versions: +Python 3.4 ___ Pytho

[issue22182] distutils.file_util.move_file unpacks wrongly an exception

Changes by Claudiu Popa : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue22182] distutils.file_util.move_file unpacks wrongly an exception

Claudiu Popa added the comment: Mm, it seems there's another instance of unpacking later on, when os.unlink fails. Here's the updated patch. -- Added file: http://bugs.python.org/file36346/issue22182.patch ___ Python tracker

[issue22182] distutils.file_util.move_file unpacks wrongly an exception

New submission from Claudiu Popa: Hi. When os.rename fails inside distutils.file_util.move_file, the exception is unpacked using ``(num, msg) = e``. While this was valid in Python 2, in Python 3 it should be ``e.args``. The attached patched fixes this. -- components: Distutils files: d