[issue22143] rlcompleter.Completer has duplicate matches

Martin Panter added the comment: Actually more like Issue 25590 (this was about attribute names, not global names) -- superseder: Make rlcompleter avoid duplicate global names -> tab-completition on instances repeatedly accesses attribute/descriptors values ___

[issue22143] rlcompleter.Completer has duplicate matches

Martin Panter added the comment: I think this was fixed by Issue 25663. (Sorry I wasn’t aware of the work already done here.) -- nosy: +martin.panter resolution: -> out of date status: open -> closed superseder: -> Make rlcompleter avoid duplicate global names ___

[issue22143] rlcompleter.Completer has duplicate matches

Lorenz Quack added the comment: sorry it took so long but my contributor agreement is now signed. Do you want me to write a patch with the results sorted? If so, should I also change the docs to reflect that the results are sorted? This would then also affect other implementations because they

[issue22143] rlcompleter.Completer has duplicate matches

Lorenz Quack added the comment: I couldn't find anything concerning order in the docs so I didn't see any reason the have them sorted. I'm not opposed to sorting them. I guess you could call me +0 on returning sorted(set(matches)) -- ___ Python trac

[issue22143] rlcompleter.Completer has duplicate matches

Ezio Melotti added the comment: +return list(set(matches)) Shouldn't this be sorted before being returned? -- ___ Python tracker ___

[issue22143] rlcompleter.Completer has duplicate matches

Lorenz Quack added the comment: Thanks for reviewing! test now use assertIn and assertIsNone as suggested PS: My Contributors Agreement is in progress. Just emailed the PSF with some question (but I intend to sign it) -- Added file: http://bugs.python.org/file37074/rlcompleter_22143.p

[issue22143] rlcompleter.Completer has duplicate matches

Claudiu Popa added the comment: I don't know why there's no review link for your patch. Anyway.. +self.assertTrue(c.complete("A.foo", 0) in ['A.foo(', 'A.foobar(']) +self.assertTrue(c.complete("A.foo", 1) in ['A.foo(', 'A.foobar(']) You can use self.assertIn for these. +

[issue22143] rlcompleter.Completer has duplicate matches

Lorenz Quack added the comment: Hi, here finally the updated patch with test case. It depends on and should be applied after the patch included in issue22141. This patch does changes two things: 1) completions are now unique 2) completions are now in no specific order I had to touch some other

[issue22143] rlcompleter.Completer has duplicate matches

Claudiu Popa added the comment: The patch looks good. Could you add a test? -- nosy: +Claudiu.Popa ___ Python tracker ___ ___ Python-b

[issue22143] rlcompleter.Completer has duplicate matches

Changes by Ezio Melotti : -- nosy: +ezio.melotti stage: -> patch review type: -> behavior versions: -Python 3.1, Python 3.2, Python 3.3 ___ Python tracker ___

[issue22143] rlcompleter.Completer has duplicate matches

New submission from Lorenz Quack: Example: >>> import rlcompleter >>> completer = rlcompleter.Completer() >>> class A(object): ... foo = None >>> class B(A): ... pass >>> b = B() >>> print([completer.complete("b.foo", i) for i in range(4)]) ['b.foo', 'b.foo', 'b.foo', None] I would expec