[issue22065] Update turtledemo menu creation

2014-08-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: Since the menu argument was the 'opposite' of the stop argument, both in theory and practice, it was never needed as a parameter/argument. configGUI could have had the following first line to create it. menu = NORMAL if stop == DISABLED else DISABLED -

[issue22065] Update turtledemo menu creation

2014-08-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset a94d9c981461 by Terry Jan Reedy in branch '3.4': Issue #22065: Remove the now unsed configGUI menu parameter and arguments. http://hg.python.org/cpython/rev/a94d9c981461 -- ___ Python tracker

[issue22065] Update turtledemo menu creation

2014-08-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: Before the patch, the Examples menu was disabled while a demo was running by setting the Menubutton state to DISABLED versus NORMAL. This does not work for the cascaded Menu. The result was buggy behavior when loading a new demo while the previous one was run

[issue22065] Update turtledemo menu creation

2014-08-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset b671092e08fa by Terry Jan Reedy in branch '3.4': Issue #22065: Menus, unlike Menubottons, do not have a state option. http://hg.python.org/cpython/rev/b671092e08fa -- ___ Python tracker

[issue22065] Update turtledemo menu creation

2014-08-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: The changes to help menu creation in #22053 required hand patching of the last chunk, but that was pretty easy. The code definitely looks better for the change. After pushing, I compared the look to 2.7. The first letters are not underlined, but Alt- works, a

[issue22065] Update turtledemo menu creation

2014-08-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 39c67beb483a by Terry Jan Reedy in branch '3.4': Issue #22065: Update turtledemo menu creation; don't use obsolete Menubutton. http://hg.python.org/cpython/rev/39c67beb483a -- ___ Python tracker

[issue22065] Update turtledemo menu creation

2014-08-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: The two misdirected and unlinked changeset notices belong to #22053. (Not completely off, as they synchronize 3.4 and 3.5 so I can start work on this.) -- ___ Python tracker _

[issue22065] Update turtledemo menu creation

2014-08-14 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- Removed message: http://bugs.python.org/msg225332 ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue22065] Update turtledemo menu creation

2014-08-14 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- Removed message: http://bugs.python.org/msg225333 ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue22065] Update turtledemo menu creation

2014-08-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 59cc3bfdac4b by Terry Jan Reedy in branch 'default': Issue #22065: Try the delete demohelp.txt part again. http://hg.python.org/cpython/rev/59cc3bfdac4b -- ___ Python tracker

[issue22065] Update turtledemo menu creation

2014-08-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4349bbc21ca7 by Terry Jan Reedy in branch 'default': Issue #22065: forward port the changes in c26862955342, update docstring with http://hg.python.org/cpython/rev/4349bbc21ca7 -- nosy: +python-dev ___ Py

[issue22065] Update turtledemo menu creation

2014-08-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: # 3 on my list of patches to review and apply -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue22065] Update turtledemo menu creation

2014-08-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Terry? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue22065] Update turtledemo menu creation

2014-07-25 Thread Ned Deily
Ned Deily added the comment: Nice insight, Serhly! The patch addresses the menu concern I brought up in msg223631 of Issue21933. I evaluated the patch with all three OS X Tk variants (Cocoa, Carbon, and X11) and it looked good to me. The only review comment I have is that ideally, with Coco

[issue22065] Update turtledemo menu creation

2014-07-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is updated patch. * Excluded the tkinter_restore_empty_methods.patch. * Synchronized with tip. * Corrected grid row indices (this doesn't matter, in any case menu was removed from grid on Mac). Current code doesn't work as was designed (with using obsol

[issue22065] Update turtledemo menu creation

2014-07-25 Thread Terry J. Reedy
New submission from Terry J. Reedy: On #22061, Serhiy Storchaka posted turtledemo_menu.patch, which is unrelated to that issue. Issues in that patch. * It mistakenly includes the tkinter_restore_empty_methods.patch that does belongs to 22061. * It will not apply any more, especially to 3.4 as i