[issue22002] Make full use of test discovery in test subpackages

Zachary Ware added the comment: Committed with a couple of changes from the posted patch: commented on the multiple dirname() calls as Serhiy suggested, removed the 'with DirsOnSysPath():' line since it turns out to be unnecessary when supplying top_level_dir to loader.discover(), and added so

[issue22002] Make full use of test discovery in test subpackages

Roundup Robot added the comment: New changeset 4f9f7e0fe1fd by Zachary Ware in branch '3.4': Issue #22002: Make full use of test discovery in test sub-packages. http://hg.python.org/cpython/rev/4f9f7e0fe1fd New changeset 6298895a52de by Zachary Ware in branch 'default': Closes #22002: Merge with

[issue22002] Make full use of test discovery in test subpackages

Serhiy Storchaka added the comment: Nice. Could you please comment multiple dirname()-s in load_package_tests() as it done for basename in Lib/test/test_tools/__init__.py? -- ___ Python tracker ___

[issue22002] Make full use of test discovery in test subpackages

Zachary Ware added the comment: Victor, could you give me a yay or nay on the test_asyncio change? -- nosy: +haypo ___ Python tracker ___

[issue22002] Make full use of test discovery in test subpackages

Zachary Ware added the comment: Thank you, Brett and David. @Mark: This issue is a continuation of the #16748 effort (#16748 is a meta-issue for this kind of thing) and unrelated to #10572 (though this will add a feature to test.support that can be useful for the scattered test packages). --

[issue22002] Make full use of test discovery in test subpackages

Mark Lawrence added the comment: I'm getting lost in all the enhancement requests for tests. How does this relate to e.g. 16748 or 10572? -- nosy: +BreamoreBoy ___ Python tracker _

[issue22002] Make full use of test discovery in test subpackages

R. David Murray added the comment: I have no problem with the change to test_email. (I could have sworn I tried unittest.main() in __main__ when I set it up, but I must have screwed something up). I didn't go over the patch line by line, but it looks good to me. -- nosy: +r.david.mur

[issue22002] Make full use of test discovery in test subpackages

Brett Cannon added the comment: I can confirm everything you said is accurate, Zachary. And I very much look forward to the results of the patch. =) -- ___ Python tracker ___ __

[issue22002] Make full use of test discovery in test subpackages

New submission from Zachary Ware: Here's a patch against 3.4 implementing Serhiy's suggestion in msg223277 and taking it a step further, actually using test discovery in all of the test.test_* subpackages. To reduce duplication, the patch adds a 'load_package_tests' function to test.support,