[issue21958] Allow python 2.7 to compile with Visual Studio 2013

2014-07-25 Thread Zachary Ware
Zachary Ware added the comment: Thanks for the patch, I've committed it. For future reference, the devguide should answer any questions you may have about how to contribute to Python, or you can ask on any of the various mailing lists (where you'll either get an answer or be pointed to a list

[issue21958] Allow python 2.7 to compile with Visual Studio 2013

2014-07-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset cb2e1b3a395f by Zachary Ware in branch '2.7': Issue #21958: Define HAVE_ROUND when building with VS 2013 and above. http://hg.python.org/cpython/rev/cb2e1b3a395f New changeset 1c35cefd25b7 by Zachary Ware in branch '3.4': Issue #21958: Define HAVE_R

[issue21958] Allow python 2.7 to compile with Visual Studio 2013

2014-07-11 Thread Zachary Turner
Zachary Turner added the comment: That's fine with me, the HAVE_ROUND is the important change anyway. Do I need to re-upload a new patch, or are you able to just delete the VS2013 project files portion of the patch and apply the HAVE_ROUND portion? And do I push the patch myself or does some

[issue21958] Allow python 2.7 to compile with Visual Studio 2013

2014-07-11 Thread Zachary Ware
Zachary Ware added the comment: Agreed. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue21958] Allow python 2.7 to compile with Visual Studio 2013

2014-07-11 Thread Steve Dower
Steve Dower added the comment: The fix is certainly needed in default, though I already have it in my fork for porting to VC14. I'm okay with the HAVE_ROUND change, but I think the VS2013 project files are better off kept separate. We won't be rebuilding 2.x with a newer compiler, so they don

[issue21958] Allow python 2.7 to compile with Visual Studio 2013

2014-07-11 Thread Zachary Turner
New submission from Zachary Turner: VS2013 and beyond implement C99 math functions. Of interest to Python is the function round(). Python conditionally provides its own implementation of round() based on whether or not HAVE_ROUND is defined, but in no case is HAVE_ROUND ever defined. This l