[issue21947] `Dis` module doesn't know how to disassemble generators

Changes by Nick Coghlan : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-l

[issue21947] `Dis` module doesn't know how to disassemble generators

Nick Coghlan added the comment: Thanks for the patch Clement! Could I also please request that you sign the Contributor License Agreement at https://www.python.org/psf/contrib/contrib-form/ While we have some discretion to accept "small" patches without one, a signed CLA helps assure that we

[issue21947] `Dis` module doesn't know how to disassemble generators

Roundup Robot added the comment: New changeset 2ae5709692ef by Nick Coghlan in branch 'default': Issue #21947: handle generator-iterator objects in dis http://hg.python.org/cpython/rev/2ae5709692ef -- nosy: +python-dev ___ Python tracker

[issue21947] `Dis` module doesn't know how to disassemble generators

Clement Rouault added the comment: Updated some docstrings in the new patch after the review comments. Thanks kushou for the code review. -- Added file: http://bugs.python.org/file35954/dis_generator3.patch ___ Python tracker

[issue21947] `Dis` module doesn't know how to disassemble generators

Raymond Hettinger added the comment: +1 -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue21947] `Dis` module doesn't know how to disassemble generators

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue21947] `Dis` module doesn't know how to disassemble generators

hakril added the comment: Here is a try for a better patch. Added a unit test and updated the doc. -- Added file: http://bugs.python.org/file35918/dis_generator2.patch ___ Python tracker ___

[issue21947] `Dis` module doesn't know how to disassemble generators

Antoine Pitrou added the comment: That sounds like a good idea. The patch lacks a unit test, though. -- nosy: +pitrou ___ Python tracker ___ _

[issue21947] `Dis` module doesn't know how to disassemble generators

Changes by Zachary Ware : -- nosy: +ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue21947] `Dis` module doesn't know how to disassemble generators

New submission from hakril: The `dis` module doesn't know how to disassemble generator object because it has no idea about the `gi_code` attribute. I made a (very) little patch to change this behavior. If there is a valid reason to not let the `dis` module disassemble generator, I would be gla