[issue21868] Tbuffer in turtle allows negative size

Raymond Hettinger added the comment: Thanks for the patch Lita. This was a nice fix. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ _

[issue21868] Tbuffer in turtle allows negative size

Roundup Robot added the comment: New changeset 02b25ec13c94 by Raymond Hettinger in branch '3.4': Issue #21868: Prevent turtle crash due to invalid undo buffer size. http://hg.python.org/cpython/rev/02b25ec13c94 -- ___ Python tracker

[issue21868] Tbuffer in turtle allows negative size

Roundup Robot added the comment: New changeset 847a0e74c4cc by Raymond Hettinger in branch '2.7': Issue #21868: Prevent turtle crash due to invalid undo buffer size. http://hg.python.org/cpython/rev/847a0e74c4cc -- nosy: +python-dev ___ Python tracker

[issue21868] Tbuffer in turtle allows negative size

Changes by Jessica McKellar : -- keywords: +needs review stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue21868] Tbuffer in turtle allows negative size

Lita Cho added the comment: Hi Raymond! Just wanted to check if you had time to test this yet. I ran the tests through the Turtle tests I wrote (issue21914), but those are still pending approval. This is off topic, but I also didn't realize till now that you gave a talk about "Transforming Co

[issue21868] Tbuffer in turtle allows negative size

Changes by Lita Cho : -- versions: +Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue21868] Tbuffer in turtle allows negative size

Changes by Lita Cho : -- versions: +Python 3.4, Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue21868] Tbuffer in turtle allows negative size

Raymond Hettinger added the comment: I looked at this and marked it as high priority (crashes are an unacceptable outcome). The patch looks fine but I haven't had a chance to test it yet. If it passes muster, I'll apply it shortly (I'm overseas traveling this week). In the meantime, can you

[issue21868] Tbuffer in turtle allows negative size

Lita Cho added the comment: Hey Raymond, just wanted to ping you to see if you had a chance to review this patch yet. Thanks! -- ___ Python tracker ___ _

[issue21868] Tbuffer in turtle allows negative size

Lita Cho added the comment: I should clarify. The right thing being that calling undo does nothing, and turtle keeps on running. This is the default behaviour when setundobuffer is called with no size. -- ___ Python tracker

[issue21868] Tbuffer in turtle allows negative size

Changes by Raymond Hettinger : -- assignee: -> rhettinger nosy: +rhettinger priority: normal -> high ___ Python tracker ___ ___ Pytho

[issue21868] Tbuffer in turtle allows negative size

Lita Cho added the comment: Here is a patch for this bug. Basically, when a user gives 0 and below, it doesn't create a TBuffer. Then "undo" does the right thing. -- keywords: +patch Added file: http://bugs.python.org/file35778/undobuffer_fix.patch _

[issue21868] Tbuffer in turtle allows negative size

Changes by Lita Cho : -- nosy: +jesstess ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue21868] Tbuffer in turtle allows negative size

New submission from Lita Cho: Currently, you can set the undobuffer size to negative numbers. Aka, the Tbuffer can be set to negative. s = turtle.Screen() raw = turtle.RawTurtle(s) raw.setundobuffer(-10) raw.undobuffer.bufsize == -10 <-- returns True This should not be possible. Tbuffer should