[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails

Roundup Robot added the comment: New changeset d4694c672c36 by Serhiy Storchaka in branch '3.4': Issue #21802: The reader in BufferedRWPair now is closed even when closing https://hg.python.org/cpython/rev/d4694c672c36 New changeset f515c7ccff57 by Serhiy Storchaka in branch 'default': Issue #21

[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails

Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails

Serhiy Storchaka added the comment: Ping. If this patch will be accepted I'll provide larger patch for similar issues in close methods of other classes. -- ___ Python tracker _

[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails

Serhiy Storchaka added the comment: Because this API was not still committed. Here is a patch which uses it. -- Added file: http://bugs.python.org/file37271/bufferedrwpair_close_2.patch ___ Python tracker _

[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails

Antoine Pitrou added the comment: Why don't you reuse the API from issue21715? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails

Serhiy Storchaka added the comment: Antoine, what do you think about this? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails

New submission from Serhiy Storchaka: Current implementation of BufferedRWPair.close() is: def close(self): self.writer.close() self.reader.close() When self.writer.close() raises an exception, self.reader left non-closed. This can cause file description leak unless GC swee