[issue21790] Change blocksize in http.client to the value of resource.getpagesize

Change by Berker Peksag : -- stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue21790] Change blocksize in http.client to the value of resource.getpagesize

Martin Panter added the comment: Issue 31945 proposes adding a “blocksize” parameter to HTTPConnection objects, so I suggest to closing in favour of that one. -- resolution: -> rejected superseder: -> Configurable blocksize in HTTP(S)Connection __

[issue21790] Change blocksize in http.client to the value of resource.getpagesize

Martin Panter added the comment: For plain-text (non-SSL) HTTP uploads, perhaps using “socket.sendfile” would help: Issue 13559. Another idea would be to expose and document the low-level socket (or SSL wrapper) and let the user copy data with whatever chunk size they desire. -- nosy:

[issue21790] Change blocksize in http.client to the value of resource.getpagesize

Clay Gerrard added the comment: I don't think the default is bad/wrong so much as it's an inflexible magic number. I think blocksize should be parameterized as an attribute on the connection - or at least a class attribute or module level constant so we can monkey patch it without having to c

[issue21790] Change blocksize in http.client to the value of resource.getpagesize

Demian Brecht added the comment: I very well could be missing something here (and, admittedly, my OS knowledge is rusty at best), but for the most part, page sizes are 4096, except for SPARC, which is 8192. > So your page double the number of calls to read(), right? No. read() is called until

[issue21790] Change blocksize in http.client to the value of resource.getpagesize

STINNER Victor added the comment: > When sending data, the blocksize is currently hardcoded to 8192. Yeah, same value for io.DEFAULT_BUFFER_SIZE. > It should likely be set to the value of resource.getpagesize(). Could you please elaborate? A page size is 4096 bytes on my Linux. So your page d

[issue21790] Change blocksize in http.client to the value of resource.getpagesize

Demian Brecht added the comment: Updated to mmap.PAGESIZE, which seems to be available on all systems. -- Added file: http://bugs.python.org/file35707/issue21790.patch ___ Python tracker ___

[issue21790] Change blocksize in http.client to the value of resource.getpagesize

Claudiu Popa added the comment: resource module is available only on Unix. -- nosy: +Claudiu.Popa ___ Python tracker ___ ___ Python-bu

[issue21790] Change blocksize in http.client to the value of resource.getpagesize

New submission from Demian Brecht: When sending data, the blocksize is currently hardcoded to 8192. It should likely be set to the value of resource.getpagesize(). -- components: Library (Lib) files: set_blocksize_to_getpagesize.diff keywords: patch messages: 220839 nosy: dbrecht priori