[issue21758] Not so correct documentation about asyncio.subprocess_shell method

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue21758] Not so correct documentation about asyncio.subprocess_shell method

STINNER Victor added the comment: A "string" can be a bytes string or a character string. I modified the documentation to be more explicitly, but IMO it's fine to keep "string" term in unit tests and error messages. You should not get the "string" error message if you pass a bytes or str objec

[issue21758] Not so correct documentation about asyncio.subprocess_shell method

Roundup Robot added the comment: New changeset 24c356168cc8 by Victor Stinner in branch '3.4': Closes #21758: asyncio doc: mention explicitly that subprocess parameters are http://hg.python.org/cpython/rev/24c356168cc8 New changeset b57cdb945bf9 by Victor Stinner in branch 'default': (Merge 3.4)

[issue21758] Not so correct documentation about asyncio.subprocess_shell method

STINNER Victor added the comment: IMO it's fine to support bytes on UNIX, os.fsencode() is well defined. On Windows, we may use the same decoder. -- ___ Python tracker ___ __

[issue21758] Not so correct documentation about asyncio.subprocess_shell method

New submission from Vajrasky Kok: subprocess_shell in asyncio accepts cmd as a string or a bytes but the test unit, the documentation and the exception indicates that it only accepts a string. -- assignee: docs@python components: Documentation, asyncio files: fix_doc_asyncio_subprocess