[issue21729] Use `with` statement in dbm.dumb

Serhiy Storchaka added the comment: Thanks Claudiu. Committed with yet one "with". -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker __

[issue21729] Use `with` statement in dbm.dumb

Roundup Robot added the comment: New changeset fdbcb11e0323 by Serhiy Storchaka in branch '3.4': Issue #21729: Used the "with" statement in the dbm.dumb module to ensure http://hg.python.org/cpython/rev/fdbcb11e0323 New changeset e41b4e8c0c1d by Serhiy Storchaka in branch 'default': Issue #21729

[issue21729] Use `with` statement in dbm.dumb

Serhiy Storchaka added the comment: Ah, month ago I wrote large patch which use 'with' in various places in stdlib for opening and closing files. But then I dropped it because afraid that it can be considered as code churn. -- stage: patch review -> commit review versions: +Python 2.7,

[issue21729] Use `with` statement in dbm.dumb

Raymond Hettinger added the comment: Serhiy, after reviewing this, consider backporting it. The original code doesn't have a try/finally around the close() call and that could be considered a bug. -- nosy: +rhettinger ___ Python tracker

[issue21729] Use `with` statement in dbm.dumb

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka priority: normal -> low stage: -> patch review ___ Python tracker ___ ___

[issue21729] Use `with` statement in dbm.dumb

New submission from Claudiu.Popa: Hello. Here's a short patch for dbm.dumb, which uses in various places the `with` statement for opening and closing files. Thanks. -- components: Library (Lib) files: dbm_with_open.patch keywords: patch messages: 220335 nosy: Claudiu.Popa, serhiy.storc