[issue2168] gdbm needs to be iterable

Raymond Hettinger added the comment: Thx. __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailm

[issue2168] gdbm needs to be iterable

Facundo Batista added the comment: Applied in r61072. Raymond, I stole this from you, because I had the same conclusion and it was very needed for the buildbot. Thank you all! -- nosy: +facundobatista resolution: -> accepted status: open -> closed __

[issue2168] gdbm needs to be iterable

Neal Norwitz added the comment: Thomas, thanks for fixing this. I didn't see any specific problems with the patch, but I'm wondering why the code doesn't just call has_key in both cases? -- nosy: +nnorwitz __ Tracker <[EMAIL PROTECTED]>

[issue2168] gdbm needs to be iterable

Changes by Raymond Hettinger: -- assignee: -> rhettinger __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue2168] gdbm needs to be iterable

Raymond Hettinger added the comment: The patch looks good to my eye, but I can't test it directly. Will apply and see what the buildbots think about it. -- nosy: +rhettinger priority: -> high __ Tracker <[EMAIL PROTECTED]>

[issue2168] gdbm needs to be iterable

Thomas Herve added the comment: Attached files add contains method to dbm and gdbm objects. It fixes failures with test_shelve. I'm ready to add more tests for this, but #1960 should probably go in first (it converts the tests to unittest, and add some coverage). Please review!

[issue2168] gdbm needs to be iterable

Changes by Thomas Herve: Added file: http://bugs.python.org/file9532/gdbm.diff __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsu

[issue2168] gdbm needs to be iterable

Changes by Thomas Herve: -- keywords: +patch Added file: http://bugs.python.org/file9531/dbm.diff __ Tracker <[EMAIL PROTECTED]> __ ___ Python-b

[issue2168] gdbm needs to be iterable

New submission from Thomas Herve: A recent change in shelve (r60927) raises the need for gdbm objects to be iterable. We can see it by running test_shelve on a machine with gdbm. I'll try to fix this. The same thing should be done with the dbm module I think. -- components: Library (Lib