[issue21636] test_logging fails on Windows for Unix tests

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue21636] test_logging fails on Windows for Unix tests

Roundup Robot added the comment: New changeset d7a491c6cbdb by Victor Stinner in branch '3.4': Issue #21636: Fix test_logging, skip UNIX stream (AF_UNIX) tests on Windows. http://hg.python.org/cpython/rev/d7a491c6cbdb New changeset b49e366556ba by Victor Stinner in branch 'default': (Merge 3.4)

[issue21636] test_logging fails on Windows for Unix tests

STINNER Victor added the comment: > No, because the tests will be skipped after the assignment of the address > family. Ah yes, the body of the class is executed before the decorator. -- ___ Python tracker __

[issue21636] test_logging fails on Windows for Unix tests

Claudiu.Popa added the comment: No, because the tests will be skipped after the assignment of the address family. -- ___ Python tracker ___ _

[issue21636] test_logging fails on Windows for Unix tests

STINNER Victor added the comment: +if threading and hasattr(socket, "AF_UNIX"): The check on socket.AF_UNIX attribute looks redundant: there is already a decorator on the testcase class to skip the whole test case. No? -- ___ Python tracker

[issue21636] test_logging fails on Windows for Unix tests

STINNER Victor added the comment: Oh, it looks like a follow-up of the issue #21583 (change f1393e82660819996e74c7eeddc5ae1f38b15f0a), the test was already buggy but not run before. -- nosy: +diana, haypo, python-dev versions: +Python 3.4 ___ Python

[issue21636] test_logging fails on Windows for Unix tests

New submission from Claudiu.Popa: Hello! The attached patch fixes a crash for the logging tests on Windows. That's because the tests assume that socket.AF_UNIX exists. The actual traceback is: [1/1] test_logging test test_logging crashed -- Traceback (most recent call last): File "D:\Project