[issue21452] make_buildinfo.exe with VS2013 fails due ill-formed IntDir path

2014-05-12 Thread Mateusz Łoskot
Mateusz Łoskot added the comment: On 9 May 2014 19:21, Tim Golden wrote: > > Fixed. Thanks for the report > Thank you for the fix. -- ___ Python tracker ___ ___

[issue21452] make_buildinfo.exe with VS2013 fails due ill-formed IntDir path

2014-05-09 Thread Tim Golden
Tim Golden added the comment: Fixed. Thanks for the report -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue21452] make_buildinfo.exe with VS2013 fails due ill-formed IntDir path

2014-05-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 469837abe5ca by Tim Golden in branch '3.4': Issue21452 Add missing backslash to build path for make_buildinfo http://hg.python.org/cpython/rev/469837abe5ca New changeset a14420d8b556 by Tim Golden in branch 'default': Issue21452 Add missing backslas

[issue21452] make_buildinfo.exe with VS2013 fails due ill-formed IntDir path

2014-05-09 Thread Zachary Ware
Zachary Ware added the comment: Your patch looks fine to me, Tim. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue21452] make_buildinfo.exe with VS2013 fails due ill-formed IntDir path

2014-05-08 Thread Tim Golden
Tim Golden added the comment: Attached project patch seems to build successfully on VS2010. It's possible that this failed in some way on VS2008; AFAICT it hasn't been touched since Brian first ported it two years ago. Adding Zach Ware for a second opinion. -- nosy: +zach.ware Added f

[issue21452] make_buildinfo.exe with VS2013 fails due ill-formed IntDir path

2014-05-08 Thread Mateusz Łoskot
Mateusz Łoskot added the comment: On 8 May 2014 11:53, Tim Golden wrote: > > What effect does your patch have on a VS2010 build? I don't know. I don't use VS2010. However, I suspect the option 1) fix should be applied anyway as it is suggested by the comment in make_buildinfo.c. Why the pythonc

[issue21452] make_buildinfo.exe with VS2013 fails due ill-formed IntDir path

2014-05-08 Thread Tim Golden
Tim Golden added the comment: What effect does your patch have on a VS2010 build? VS2010 is the official toolset for current Python 3.x versions so any changes we make must support that. Also: does the same problem occur on the development branch? (De-selecting 3.2 as it's in security-fix mo

[issue21452] make_buildinfo.exe with VS2013 fails due ill-formed IntDir path

2014-05-08 Thread Mateusz Loskot
New submission from Mateusz Loskot: While building Python 3.2 or Python 3.4 with Visual Studio 2013 on Windows 8.1, pythoncore.vcxproj fails to build due to illformed pre-link event command. (FYI, I have upgraded all .vcxproj files to VS2013 locally.) Here is the command and the error: 1>PreL