[issue21391] shutil uses both os.path.abspath and an 'import from' of abspath

Berker Peksag added the comment: Done. Thanks for the reviews! -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___ _

[issue21391] shutil uses both os.path.abspath and an 'import from' of abspath

Roundup Robot added the comment: New changeset ab369d809200 by Berker Peksag in branch 'default': Issue #21391: Use os.path.abspath in the shutil module. https://hg.python.org/cpython/rev/ab369d809200 -- nosy: +python-dev ___ Python tracker

[issue21391] shutil uses both os.path.abspath and an 'import from' of abspath

Changes by Berker Peksag : -- assignee: -> berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue21391] shutil uses both os.path.abspath and an 'import from' of abspath

Serhiy Storchaka added the comment: I'm for get rid of "from import" without deprecation. Definitely this is not part of API. -- nosy: +serhiy.storchaka stage: commit review -> needs patch ___ Python tracker _

[issue21391] shutil uses both os.path.abspath and an 'import from' of abspath

Eric V. Smith added the comment: Now that I think about it, maybe we don't need a deprecation warning. http://legacy.python.org/dev/peps/pep-0008/#public-and-internal-interfaces says: "Imported names should always be considered an implementation detail. Other modules must not rely on indirect

[issue21391] shutil uses both os.path.abspath and an 'import from' of abspath

Eric V. Smith added the comment: Shouldn't the existing calls to abspath() be changed to os.path.abspath()? Or are both patches meant to be applied? I don't think the first patch applies cleanly any more. In any event: the deprecation and test look good to me. So assuming we get rid of the im

[issue21391] shutil uses both os.path.abspath and an 'import from' of abspath

Changes by Berker Peksag : -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue21391] shutil uses both os.path.abspath and an 'import from' of abspath

Berker Peksag added the comment: Here is a patch to deprecate the shutil.abspath function. -- nosy: +berker.peksag Added file: http://bugs.python.org/file35272/issue21391.diff ___ Python tracker ___

[issue21391] shutil uses both os.path.abspath and an 'import from' of abspath

R. David Murray added the comment: I'd prefer to get rid of it, otherwise we might get requests to add all the other os.path functions to the shutil namespace, and I don't think having that kind of "more than one way to do it" serves anyone. I suppose we'll have to deprecate it first if we do