[issue21375] Fix and test overflow behavior in the C version of heapq

Changes by Raymond Hettinger : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue21375] Fix and test overflow behavior in the C version of heapq

Roundup Robot added the comment: New changeset b768d41dec0a by Raymond Hettinger in branch '2.7': Issue 21375: Fix possible Py_ssizet overflow in heapq. http://hg.python.org/cpython/rev/b768d41dec0a -- ___ Python tracker

[issue21375] Fix and test overflow behavior in the C version of heapq

Roundup Robot added the comment: New changeset 725cb631699a by Raymond Hettinger in branch '3.4': Issue 21375: Fix possible Py_ssizet overflow in heapq. http://hg.python.org/cpython/rev/725cb631699a -- nosy: +python-dev ___ Python tracker

[issue21375] Fix and test overflow behavior in the C version of heapq

Tim Peters added the comment: I don't see a way to test it either, but it's easy enough to prove it's correct ;-) That is, looks good to me! -- nosy: +tim.peters ___ Python tracker ___

[issue21375] Fix and test overflow behavior in the C version of heapq

Raymond Hettinger added the comment: Attaching a fix. I can't think of a way to test this without an array of sys.maxsize. -- keywords: +patch Added file: http://bugs.python.org/file35088/fix_overflow.diff ___ Python tracker

[issue21375] Fix and test overflow behavior in the C version of heapq

New submission from Raymond Hettinger: The Py_ssizet indexes can overflow the "childpos" variable: childpos = 2*pos + 1;/* leftmost child position */ while (childpos < endpos) ... http://googleresearch.blogspot.com/2006/06/extra-extra-read-all-about-it-nearly.html -- assi