[issue21349] crash in winreg SetValueEx with memoryview

Tim Golden added the comment: Committed. Thanks for the patch. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue21349] crash in winreg SetValueEx with memoryview

Roundup Robot added the comment: New changeset 9c38cfc7bed7 by Tim Golden in branch '2.7': Add NEWS entry for issue21349 http://hg.python.org/cpython/rev/9c38cfc7bed7 -- ___ Python tracker _

[issue21349] crash in winreg SetValueEx with memoryview

Roundup Robot added the comment: New changeset 061db174baad by Tim Golden in branch '2.7': Issue21349 Passing a memoryview to _winreg.SetValueEx now correctly raises a TypeError where it previously crashed the interpreter. Patch by Brian Kearns http://hg.python.org/cpython/rev/061db174baad

[issue21349] crash in winreg SetValueEx with memoryview

Antoine Pitrou added the comment: > Are you aware of the old/new buffer interfaces and their usages? Did > you actually try the code? "crash" would be obvious. I cannot try the code as I'm under Linux :-) I was asking merely because many people report plain exception tracebacks as "crashes". Yes

[issue21349] crash in winreg SetValueEx with memoryview

Tim Golden added the comment: I can confirm that the problem (which really is a hard crash) only applies to 2.7 and that the patch tests and fixes it. I'm happy to apply. Any objections? -- assignee: -> tim.golden nosy: +tim.golden ___ Python tracke

[issue21349] crash in winreg SetValueEx with memoryview

Brian Kearns added the comment: Are you aware of the old/new buffer interfaces and their usages? Did you actually try the code? "crash" would be obvious. Objects that support only the new buffer interface define tp_as_buffer with fields representing the old buffer interface as null. So, every

[issue21349] crash in winreg SetValueEx with memoryview

Antoine Pitrou added the comment: Brian, it's not obvious (to me) what the original issue is ("crash"?) and why the new test expects a TypeError. Also, is it a 2.7-only issue or does it also affect Python 3? -- nosy: +pitrou, stutzbach ___ Python tra

[issue21349] crash in winreg SetValueEx with memoryview

Changes by Brian Kearns : Removed file: http://bugs.python.org/file35031/fix_winreg_setvalueex-py27.patch ___ Python tracker ___ ___ Python-bu

[issue21349] crash in winreg SetValueEx with memoryview

Brian Kearns added the comment: Oops, updated test. -- Added file: http://bugs.python.org/file35038/fix_winreg_setvalueex-py27.patch ___ Python tracker ___ __

[issue21349] crash in winreg SetValueEx with memoryview

New submission from Zachary Ware: The new test fails with the patch applied: == ERROR: test_setvalueex_with_memoryview (__main__.LocalWinregTests) -- Traceback

[issue21349] crash in winreg SetValueEx with memoryview

Changes by Berker Peksag : -- nosy: +zach.ware ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue21349] crash in winreg SetValueEx with memoryview

Changes by Brian Kearns : Added file: http://bugs.python.org/file35031/fix_winreg_setvalueex-py27.patch ___ Python tracker ___ ___ Python-bugs

[issue21349] crash in winreg SetValueEx with memoryview

Changes by Brian Kearns : Removed file: http://bugs.python.org/file35030/fix_winreg_setvalueex-py27.patch ___ Python tracker ___ ___ Python-bu

[issue21349] crash in winreg SetValueEx with memoryview

Changes by Brian Kearns : -- files: fix_winreg_setvalueex-py27.patch keywords: patch nosy: bdkearns priority: normal severity: normal status: open title: crash in winreg SetValueEx with memoryview type: crash versions: Python 2.7 Added file: http://bugs.python.org/file35030/fix_winreg_se