[issue21226] PyImport_ExecCodeModuleObject not setting module attributes

2014-05-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset baa7b656 by Eric Snow in branch '3.4': Issue #21226: fix a ref leak. http://hg.python.org/cpython/rev/baa7b656 New changeset 57130574d1e8 by Eric Snow in branch 'default': Issue #21226: Merge from 3.4. http://hg.python.org/cpython/rev/571305

[issue21226] PyImport_ExecCodeModuleObject not setting module attributes

2014-05-12 Thread Eric Snow
Changes by Eric Snow : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Pyth

[issue21226] PyImport_ExecCodeModuleObject not setting module attributes

2014-05-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7d20e30bd540 by Eric Snow in branch '3.4': Issue #21226: Set all attrs in PyImport_ExecCodeModuleObject. http://hg.python.org/cpython/rev/7d20e30bd540 New changeset bc324a49d0fc by Eric Snow in branch 'default': Merge from 3.4 (for #21226). http://h

[issue21226] PyImport_ExecCodeModuleObject not setting module attributes

2014-05-11 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue21226] PyImport_ExecCodeModuleObject not setting module attributes

2014-05-09 Thread Brett Cannon
Brett Cannon added the comment: LGTM although you forgot to use a loader instance instead of the class. -- ___ Python tracker ___ ___

[issue21226] PyImport_ExecCodeModuleObject not setting module attributes

2014-04-19 Thread Eric Snow
Eric Snow added the comment: Thanks, Benjamin. Here's an updated patch that passes all tests. It should be good to go. And yet again our zipimport implementation was a pain point. :( -- Added file: http://bugs.python.org/file34980/fix-PyImport_ExecCodeModuleObject.diff

[issue21226] PyImport_ExecCodeModuleObject not setting module attributes

2014-04-19 Thread Benjamin Peterson
Benjamin Peterson added the comment: The last argument to _PyObject_CallMethodIdObjArgs needs to be NULL... -- nosy: +benjamin.peterson ___ Python tracker ___ ___

[issue21226] PyImport_ExecCodeModuleObject not setting module attributes

2014-04-19 Thread Eric Snow
Eric Snow added the comment: Here's a (currently segfaulting) patch that demonstrates how I'd like to solve this. Feedback on the approach is welcome. :) When I get a chance I'll debug the segfault. -- assignee: -> eric.snow keywords: +patch stage: -> patch review Added file: http

[issue21226] PyImport_ExecCodeModuleObject not setting module attributes

2014-04-14 Thread Trevor Caira
New submission from Trevor Caira: In Python/import.c, PyImport_ExecCodeModuleObject creates a new module object but doesn't set all of the attributes required for modules, such as __spec__ or __loader__. This breaks mod_wsgi from 3.3 and up, which depends on PyImport_ExecCodeModuleEx, which d