[issue21099] Switch applicable importlib tests to use PEP 451 API

Changes by Eric Snow : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6 -Python 3.4, Python 3.5 ___ Python tracker ___ __

[issue21099] Switch applicable importlib tests to use PEP 451 API

Roundup Robot added the comment: New changeset fceaa0dc715e by Eric Snow in branch 'default': Issue #21099: Switch applicable importlib tests to use PEP 451 API. https://hg.python.org/cpython/rev/fceaa0dc715e -- nosy: +python-dev ___ Python tracker <

[issue21099] Switch applicable importlib tests to use PEP 451 API

Brett Cannon added the comment: Patch LGTM -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue21099] Switch applicable importlib tests to use PEP 451 API

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue21099] Switch applicable importlib tests to use PEP 451 API

Brett Cannon added the comment: I'll try to get to it today or tomorrow. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue21099] Switch applicable importlib tests to use PEP 451 API

Eric Snow added the comment: Could I get a quick review on this. There shouldn't be anything surprising or controversial here. I'm pretty confident about the patch and it's pretty low-impact so if I don't hear back in the next day or two I'll merge it. Note: the posted patch does not apply c

[issue21099] Switch applicable importlib tests to use PEP 451 API

Mark Lawrence added the comment: To echo Brett's question, should this be closed, Eric? -- status: pending -> open ___ Python tracker ___

[issue21099] Switch applicable importlib tests to use PEP 451 API

Brett Cannon added the comment: Should this be closed, Eric? -- status: open -> pending ___ Python tracker ___ ___ Python-bugs-list ma

[issue21099] Switch applicable importlib tests to use PEP 451 API

Mark Lawrence added the comment: Can we have a patch review please as #18864 is dependent on this. -- nosy: +BreamoreBoy ___ Python tracker ___ __

[issue21099] Switch applicable importlib tests to use PEP 451 API

Eric Snow added the comment: Here's a patch. In most spots I'm left things alone. There is a comment in the docstring for test_abc.SourceOnlyLoaderTests about reload-related tests and module_for_loader (which is deprecated now). I'm not going to worry about that for now. -- keywords

[issue21099] Switch applicable importlib tests to use PEP 451 API

Eric Snow added the comment: Agreed. :) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue21099] Switch applicable importlib tests to use PEP 451 API

Nick Coghlan added the comment: New tests please - we want to make sure these keep working unless/until we reach agreement to actually remove them, and I'd prefer not to raise any new barriers to migration from Python 2.6/7 until 3.6 at the earliest :) -- _

[issue21099] Switch applicable importlib tests to use PEP 451 API

New submission from Eric Snow: (from msg202657 in issue 18864) A bunch of importlib (and other?) tests make direct calls to find_module(), find_loader(), or load_module(). These are still working, as expected. However, we should probably either replace them or supplement them with equivalen