[issue21085] compile error Python3.3 on Cygwin

Zachary Ware added the comment: Thanks for the patch, masamoto, and thanks for the review and rebase, erik.bray! I only applied this to 3.7. It's much more open to experimentation currently, and we have a way to go before Python can even be built on Cygwin. Once we reach a more stable point

[issue21085] compile error Python3.3 on Cygwin

Roundup Robot added the comment: New changeset 6874928eae4b by Zachary Ware in branch 'default': Issue #21085: add configure check for siginfo_t.si_band https://hg.python.org/cpython/rev/6874928eae4b -- nosy: +python-dev ___ Python tracker

[issue21085] compile error Python3.3 on Cygwin

R. David Murray added the comment: I think it would be reasonable to apply it, unless other devs object, given your confirmation that it solves this particular problem (and, looking at the code, it won't break anything...which the buildbots will confirm). This will only be applied to 3.5 and 3

[issue21085] compile error Python3.3 on Cygwin

Erik Bray added the comment: I've reviewed masamoto's last patch 3.5-issue21085-struct_siginfo-2.patch It applies cleanly and allows the signals module to compile on Cygwin64 2.5.1 / Windows 10. I attached versions of the patch that apply cleanly to tip, 3.4, and 3.3 as well. However, even w

[issue21085] compile error Python3.3 on Cygwin

Changes by Erik Bray : Added file: https://bugs.python.org/file44264/3.3-issue21085-struct_siginfo-2.patch ___ Python tracker ___ ___ Python

[issue21085] compile error Python3.3 on Cygwin

Changes by Erik Bray : Added file: https://bugs.python.org/file44262/tip-issue21085-struct_siginfo-2.patch ___ Python tracker ___ ___ Python

[issue21085] compile error Python3.3 on Cygwin

Changes by Erik Bray : Added file: https://bugs.python.org/file44263/3.4-issue21085-struct_siginfo-2.patch ___ Python tracker ___ ___ Python

[issue21085] compile error Python3.3 on Cygwin

Erik Bray added the comment: Thanks Masayuki for the updated patch. I agree, the new approach looks better. I will review the patch more carefully and test it soon. -- stage: -> patch review ___ Python tracker

[issue21085] compile error Python3.3 on Cygwin

Changes by Erik Bray : -- assignee: -> erik.bray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue21085] compile error Python3.3 on Cygwin

Masayuki Yamamoto added the comment: Oh, I made a mistake that is checking the si_band field without signal header. Here is a modified patch adding signal header at checking the si_band field. I passed tests compiling cpython 3.5.2+ on ubuntu 16.04.1 (x86) using this patch. -- Added fil

[issue21085] compile error Python3.3 on Cygwin

Masayuki Yamamoto added the comment: Hello, I'm writer for past patch. 3.4-issue21085-struct_siginfo.patch removes si_band field from struct_siginfo if the C siginfo_t doesn't have si_band field. This modification raises a incompatibility between platforms having struct_siginfo. Now, I wrote an

[issue21085] compile error Python3.3 on Cygwin

R. David Murray added the comment: Review the patch, confirm that it works for you (please indicate what cygwin and OS version, etc you test on). Also review this issue and make sure all open concerns have been addressed by the current patch. -- __

[issue21085] compile error Python3.3 on Cygwin

Erik Bray added the comment: I've run into this recently. Is there anything I can do to shepherd this issue toward a resolution status? -- nosy: +erik.bray ___ Python tracker _

[issue21085] compile error Python3.3 on Cygwin

Masayuki Yamamoto added the comment: New patch uses configure script to set the compile condition for struct_siginfo.si_band. The script was generated from configure.ac using autoreconf. Could you make sure of having the si_band in another platform? -- Added file: http://bugs.python.o

[issue21085] compile error Python3.3 on Cygwin

STINNER Victor added the comment: > In that case, May I edit configure script to generate the HAVE_* defines? > I'd like to add a statement to check the si_band to configure.ac. Does Cygwin use configure? If yes, go for configure. You can copy/paste my recent change for dirent.d_type field. >

[issue21085] compile error Python3.3 on Cygwin

Masayuki Yamamoto added the comment: Victor, In that case, May I edit configure script to generate the HAVE_* defines? I'd like to add a statement to check the si_band to configure.ac. > And please generate patches not the git format. Otherwise, Rietveld is unable > to generated the "review" l

[issue21085] compile error Python3.3 on Cygwin

STINNER Victor added the comment: Could you please use a define like SIGINFO_HAS_SI_BAND? Something like: #if defined(HAVE_SIGINFO) && !defined(__CYGWIN__) /* Issue #21085: In Cygwin, siginfo_t does not have si_band field. */ # define SIGINFO_HAS_SI_BAND #endif And please generate patches

[issue21085] compile error Python3.3 on Cygwin

Masayuki Yamamoto added the comment: I wrote improved patch to remove the 'si_band'. This patch modifies the 'n_in_sequence' to conform to the number of structure members. And I tested manually for struct_siginfo. struct_siginfo objects builds well. That's all for now. $ python3.4.exe Python

[issue21085] compile error Python3.3 on Cygwin

dellair jie added the comment: Finally got it compiled on Cygwin! :) Victor, I am still having issue with the "make test" on Cygwin, hence can only do some manual testing: Output: >>> info = signal.sigwaitinfo({signal.SIGINT}) ^C >>> >>> info = signal.struct_siginfo((2, 128, 0, 0, 0, 3)) Trac

[issue21085] compile error Python3.3 on Cygwin

dellair jie added the comment: Victor, I suppose that Python needs to be built successfully before running test_signal. Three patches were applied in Python 3.4.0. However, the build failed to build _struct module. Should I open another Issue to track it? As long as the build goes through com

[issue21085] compile error Python3.3 on Cygwin

STINNER Victor added the comment: > Would you please be more specific on test_signal? Please try to compile Python 3.4 with the attached cygwin_si_band.patch applied, and then run test_signal. I would like to know if all tests pass, and if not, which tests are failing. I also would like to kno

[issue21085] compile error Python3.3 on Cygwin

dellair jie added the comment: Victor, Would you please be more specific on test_signal? Br, Dellair -- ___ Python tracker ___ ___ P

[issue21085] compile error Python3.3 on Cygwin

STINNER Victor added the comment: > So shall we close this issue? Nope. Could you please try the test described in msg215249? We might integrate https://github.com/Alexpux/MSYS2-packages/blob/master/python3/3.3.2-cygwin-siginfo.patch but it would be better to fix sigwaitinfo() if it works wit

[issue21085] compile error Python3.3 on Cygwin

dellair jie added the comment: Martin, Here is the values presented on Python 3.4.0, in fact they are the same as 3.3.2, please note the key difference. /* #undef HAVE_SIGTIMEDWAIT */ #define HAVE_SIGWAIT 1 #define HAVE_SIGWAITINFO 1 The SIGTIMEDWAIT is undef while the SIGWAIT is defined. The p

[issue21085] compile error Python3.3 on Cygwin

Roumen Petrov added the comment: dellair jie wrote: > > dellair jie added the comment: > > Applied the patch 0001-CYGWIN-issue13756-Python-make-fail-on-cygwin.patch in > case: http://bugs.python.org/issue13756 > > The build failed with parser module: > building 'parser' extension > gcc ..

[issue21085] compile error Python3.3 on Cygwin

Roumen Petrov added the comment: STINNER Victor wrote: > > STINNER Victor added the comment: > > I found this patch: > https://github.com/Alexpux/MSYS2-packages/blob/master/python3/3.3.2-cygwin-siginfo.patch Sure. It seems to me it is extracted from issue3871 . -- nosy: +rpetrov __

[issue21085] compile error Python3.3 on Cygwin

dellair jie added the comment: Martin, Thanks for the analysis! The following values came from Python 3.3.2, the #define HAVE_SIGWAITINFO 1 was without comment sign, I commented it out for the build to go through. /* #undef HAVE_SIGTIMEDWAIT */ /* #define HAVE_SIGWAITINFO 1 */ The output was

[issue21085] compile error Python3.3 on Cygwin

Martin v. Löwis added the comment: dellair: According to the compiler output, ./pyconfig.h has #define HAVE_SIGWAIT 1 #define HAVE_SIGWAITINFO 1 So why did you say (in msg215221) that the file had /* #undef HAVE_SIGTIMEDWAIT */ /* #define HAVE_SIGWAITINFO 1 */ (i.e. where do the comment sig

[issue21085] compile error Python3.3 on Cygwin

STINNER Victor added the comment: Can you try to comment si_band code in signalmodule.c, and then run test_signal to see if sigwaitinfo works on Windows? test_sigwaitinfo() uses signal.alarm(1): does it work on Windows (with Cygwin)? (sigwaitinfo doc says "Availability: Unix.") -- __

[issue21085] compile error Python3.3 on Cygwin

STINNER Victor added the comment: I found this patch: https://github.com/Alexpux/MSYS2-packages/blob/master/python3/3.3.2-cygwin-siginfo.patch -- ___ Python tracker ___ _

[issue21085] compile error Python3.3 on Cygwin

dellair jie added the comment: Martin, Certainly running on 3.4 now. The output of the command is attached. Will try to look into it tomorrow if no immediate follow up post. Br, Li -- Added file: http://bugs.python.org/file34682/signalmodule.output.txt ___

[issue21085] compile error Python3.3 on Cygwin

Martin v. Löwis added the comment: dellair jie: please focus on one issue at a time. The issue you reported here is the compile error with si_band; I will not discuss any other problems you bring up in this issue. Note that editing pyconfig.h is not a solution. It's a generated file, so it mu

[issue21085] compile error Python3.3 on Cygwin

dellair jie added the comment: Applied the patch 0001-CYGWIN-issue13756-Python-make-fail-on-cygwin.patch in case: http://bugs.python.org/issue13756 The build failed with parser module: building 'parser' extension gcc -Wno-unused-result -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I./Incl

[issue21085] compile error Python3.3 on Cygwin

dellair jie added the comment: Yes, my pleasure. After configure on Cygwin, there is pyconfig.h generated, variables are as following: /* #undef HAVE_SIGTIMEDWAIT */ /* #define HAVE_SIGWAITINFO 1 */ The error disappeared once changed HAVE_SIGWAITINFO to undef. However, it encountered another

[issue21085] compile error Python3.3 on Cygwin

Martin v. Löwis added the comment: dellair jie: would you like to work on a patch? It's fine if not, but it may then be that there is no resolution to this issue for the coming months or years (unless somebody else volunteers to write a patch). Running configure should have created pyconfig.h

[issue21085] compile error Python3.3 on Cygwin

R. David Murray added the comment: cygwin is not officially supported. We do accept patches that improve cygwin support when they are narrowly targted and well motivated. -- nosy: +r.david.murray ___ Python tracker

[issue21085] compile error Python3.3 on Cygwin

STINNER Victor added the comment: > ./Modules/signalmodule.c:745:5: error: ‘siginfo_t’ has no member named > ‘si_band’ This code is conditional, it is surrounded by: #if defined(HAVE_SIGWAITINFO) || defined(HAVE_SIGTIMEDWAIT) Does Windows support sigwaitinfo() or sigtimedwait()? I would be su

[issue21085] compile error Python3.3 on Cygwin

dellair jie added the comment: Victor, I did do ./configure, without any parameters. Should I use it with "--without-signal-module" option? Will all signals be disabled if this option is specified? >From Python document, it mentions Windows support the following signals: signal.SIGINT, signal

[issue21085] compile error Python3.3 on Cygwin

New submission from dellair jie: Folks, Is Cygwin supported by Python? We met the following error when compiling Python 3.3.2 on Cygwin 1.7.17: gcc -c -Wno-unused-result -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I. -IInclude -I./Include-DPy_BUILD_CORE -o Modules/main.o Module