[issue2091] file accepts 'rU+' as a mode

Berker Peksag added the comment: New changeset f5972cc0c9a8e3315207e2d67534f330d619af4e by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-2091: Fix typo in exception message (GH-12987) https://github.com/python/cpython/commit/f5972cc0c9a8e3315207e2d67534f330d619af4e -- _

[issue2091] file accepts 'rU+' as a mode

Change by miss-islington : -- pull_requests: +12911 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue2091] file accepts 'rU+' as a mode

Berker Peksag added the comment: New changeset 21a9ba1992775b5a833da28bfa0a9f028d1b6761 by Berker Peksag in branch 'master': bpo-2091: Fix typo in exception message (GH-12987) https://github.com/python/cpython/commit/21a9ba1992775b5a833da28bfa0a9f028d1b6761 -- nosy: +berker.peksag

[issue2091] file accepts 'rU+' as a mode

Change by Berker Peksag : -- pull_requests: +12910 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue2091] file accepts 'rU+' as a mode

Serhiy Storchaka added the comment: Perhaps the 'U' mode should just raise an exception in 3.6. -- ___ Python tracker ___ ___ Python-bu

[issue2091] file accepts 'rU+' as a mode

Changes by Robert Collins : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue2091] file accepts 'rU+' as a mode

Robert Collins added the comment: @larry thanks - that was my inclination too. Applied to 3.6 @Serhiy I've not done a warning in 3.4/3.5 because - the behaviour is already broken, this patch just catches it a lot earlier (on open rather than subsequent operations). -- ___

[issue2091] file accepts 'rU+' as a mode

Roundup Robot added the comment: New changeset 1a5bbb31f740 by Robert Collins in branch 'default': - Issue #2091: error correctly on open() with mode 'U' and '+' https://hg.python.org/cpython/rev/1a5bbb31f740 -- nosy: +python-dev ___ Python tracker <

[issue2091] file accepts 'rU+' as a mode

Larry Hastings added the comment: Yeah, considering how long this bug has been sitting around, I think we can wait for one more release for the fix. 3.6 please. -- ___ Python tracker __

[issue2091] file accepts 'rU+' as a mode

Serhiy Storchaka added the comment: I would add a warning in 3.4- (or 3.5-). The 'U' mode should not work with '+', and it can't work with '+' correctly. This is a bug that we can decide not fix by raising an exception. -- ___ Python tracker

[issue2091] file accepts 'rU+' as a mode

Robert Collins added the comment: @Larry - should this go in 3.5, or would you rather it not? -- nosy: +larry ___ Python tracker ___ __

[issue2091] file accepts 'rU+' as a mode

R. David Murray added the comment: I agree, a change that emits an error where none was emitted before should only go in the next release. With a what's new entry. It is possible there should be a deprecation or -3 warning in 2.7, but I'm not sure it is worth the effort. -- nosy: +r.

[issue2091] file accepts 'rU+' as a mode

Robert Collins added the comment: Updated patch. I'm not going to apply right now - giving it a little time to let folk chime on whether this should be applied all the way back to 3.4, or not. My inclination is to only apply it to 3.6. -- nosy: +rbcollins Added file: http://bugs.pytho

[issue2091] file accepts 'rU+' as a mode

Serhiy Storchaka added the comment: In Python 3.4+ 'U' already emits deprecation warning. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue2091] file accepts 'rU+' as a mode

Changes by Mark Lawrence : -- versions: +Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue2091] file accepts 'rU+' as a mode

Francis MB added the comment: > On the other hand, the documentation *does* mention that > 'U' is for backwards compatibility and shouldn't be used > with new code. Shouldn't be some deprecation warning somewhere? -- nosy: +francismb ___ Python track

[issue2091] file accepts 'rU+' as a mode

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue2091] file accepts 'rU+' as a mode

Changes by Ezio Melotti : -- versions: +Python 3.3, Python 3.4 -Python 3.1 ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue2091] file accepts 'rU+' as a mode

Changes by Eli Bendersky : -- nosy: -eli.bendersky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue2091] file accepts 'rU+' as a mode

John O'Connor added the comment: It seems to me that adding the proper check is a good idea. It also may not be obvious to some that 'U' is now more or less an alias for 'r'. I have updated the patch so that it at least applies. I also removed a redundant `reading = 1` -- nosy: +jcon

[issue2091] file accepts 'rU+' as a mode

Changes by Tres Seaver : -- nosy: -tseaver ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue2091] file accepts 'rU+' as a mode

Eli Bendersky added the comment: In Python 3, the documentation no longer mentions that 'U' should not work with '+' (or 'w' or 'a', for that matter), and the code throws ValueError if 'U' is used with 'w' or 'a', but not '+'. On the other hand, the documentation *does* mention that 'U' is fo

[issue2091] file accepts 'rU+' as a mode

Changes by Eli Bendersky : -- nosy: +eli.bendersky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue2091] file accepts 'rU+' as a mode

Amaury Forgeot d'Arc added the comment: Of course, the implementation is now in the io module: Modules/_io/_iomodule.c *and* Lib/_pyio.py -- nosy: +amaury.forgeotdarc ___ Python tracker

[issue2091] file accepts 'rU+' as a mode

Mark Lawrence added the comment: The patch is now way out of date to the extent that I can't find the code in fileobject.c, perhaps I'm just blind Can someone please provide a new patch, thanks. -- nosy: +BreamoreBoy versions: +Python 3.1, Python 3.2 -Python 2.6

[issue2091] file accepts 'rU+' as a mode

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue2091] file accepts 'rU+' as a mode

Changes by Brett Cannon : -- keywords: +needs review stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list m

[issue2091] file accepts 'rU+' as a mode

Changes by Antoine Pitrou : -- versions: +Python 2.7 -Python 3.1 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue2091] file accepts 'rU+' as a mode

Tres Seaver added the comment: I can confirm that: - the patch applies cleanly to the release26-maint branch, with the exception of the Misc/NEWS portion:: $ hg branch release26-maint $ ./python -E -tt Lib/test/regrtest.py test_file test_file 1 test OK. $ patch -p0 < /tmp/issue20

[issue2091] file accepts 'rU+' as a mode

Changes by Daniel Diniz : -- nosy: +benjamin.peterson, pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue2091] file accepts 'rU+' as a mode

Changes by Daniel Diniz : -- components: +IO stage: -> patch review versions: +Python 3.1 -Python 2.5 ___ Python tracker ___ ___ Pytho

[issue2091] file accepts 'rU+' as a mode

Jeff Balogh <[EMAIL PROTECTED]> added the comment: Attaching a patch that checks for '+' in the mode string, updates the docs, and tests bad mode strings. -- keywords: +patch nosy: +jbalogh Added file: http://bugs.python.org/file9697/issue2091.diff __ Tr

[issue2091] file accepts 'rU+' as a mode

Changes by Christian Heimes: -- priority: -> high __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue2091] file accepts 'rU+' as a mode

New submission from Brett Cannon: The docs on file's constructor says that the 'U' mode should not work with '+', and yet 'rU+' does not throw an error. -- components: Interpreter Core messages: 62343 nosy: brett.cannon severity: normal status: open title: file accepts 'rU+' as a mode ty