[issue20635] Fix the grid geometry manager and add tests for geometry managers

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue20635] Fix the grid geometry manager and add tests for geometry managers

Roundup Robot added the comment: New changeset 9ab1225b6cc5 by Serhiy Storchaka in branch '2.7': Issue #20635: Added tests for Tk geometry managers. http://hg.python.org/cpython/rev/9ab1225b6cc5 -- ___ Python tracker

[issue20635] Fix the grid geometry manager and add tests for geometry managers

Ned Deily added the comment: test_tk with test_geometry_managers_2-2.7.patch applied passed on OS X 10.9 linked with Carbon Tk 8.4.20, Cocoa 8.5.15, Cocoa 8.6.1, and X11 8.6.1. -- ___ Python tracker __

[issue20635] Fix the grid geometry manager and add tests for geometry managers

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20635] Fix the grid geometry manager and add tests for geometry managers

Serhiy Storchaka added the comment: Here is a patch for 2.7. -- Added file: http://bugs.python.org/file34800/test_geometry_managers_2-2.7.patch ___ Python tracker ___ ___

[issue20635] Fix the grid geometry manager and add tests for geometry managers

Roundup Robot added the comment: New changeset e8c184d8407d by Serhiy Storchaka in branch '3.4': Issue #20635: Added tests for Tk geometry managers. http://hg.python.org/cpython/rev/e8c184d8407d New changeset e8acef4f8567 by Serhiy Storchaka in branch 'default': Issue #20635: Added tests for Tk

[issue20635] Fix the grid geometry manager and add tests for geometry managers

Serhiy Storchaka added the comment: Changesets 857ddbaff14e (2.7), 6227b0ecb5fb (3.3) and b6df5f8f86d3 (default). -- ___ Python tracker ___ __

[issue20635] Fix the grid geometry manager and add tests for geometry managers

Serhiy Storchaka added the comment: Unfortunately new tests emit on 3.3 and 2.7 same warnings as in issue20567. So I have committed only the fix, without tests. -- ___ Python tracker __

[issue20635] Fix the grid geometry manager and add tests for geometry managers

Ned Deily added the comment: With test_geometry_managers_2.patch, test_tk now passes with all of the previously tested OS X Tk versions. -- ___ Python tracker ___ __

[issue20635] Fix the grid geometry manager and add tests for geometry managers

Serhiy Storchaka added the comment: My fault. I tested the patch with 8.5 and 8.6, but was too lazy to check it with 8.4. Here is updated patch with workarounded 8.4 peculiarities. I'm not sure about test_place_forget(). I have removed the check, hope this will help. Thank you Ned. -

[issue20635] Fix the grid geometry manager and add tests for geometry managers

Ned Deily added the comment: On OS X 10.9 with Cocoa Tk 8.15.0+, Cocoa Tk 8.6, and X11 Tk 8.6: == FAIL: test_place_forget (tkinter.test.test_tkinter.test_geometry_managers.PlaceTest)

[issue20635] Fix the grid geometry manager and add tests for geometry managers

Changes by Serhiy Storchaka : -- title: Fix the grid geometry manager and add -> Fix the grid geometry manager and add tests for geometry managers ___ Python tracker ___ ___

[issue20635] Fix the grid geometry manager and add

New submission from Serhiy Storchaka: Here is a patch which adds tests for Tk geometry managers (pack, place and grid). In additional it fixes the grid_columnconfigure() and grid_rowconfigure() methods which did not worked with wantobject=True (preferable and default mode). -- compone