[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Roundup Robot added the comment: New changeset 27b738209a60 by Benjamin Peterson in branch '3.4': merge backout for #20621 http://hg.python.org/cpython/rev/27b738209a60 -- ___ Python tracker ___

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Roundup Robot added the comment: New changeset 8899e4028561 by Gregory P. Smith in branch '3.3': Mention issue 20621 fix in the NEWS file for 3.3.5rc1. http://hg.python.org/cpython/rev/8899e4028561 -- ___ Python tracker

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Paul Moore added the comment: Should this be mentioned in the 3.3.5 changelog (http://docs.python.org/3.3/whatsnew/changelog.html)? -- ___ Python tracker ___ ___

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Gregory P. Smith added the comment: there's a separate issue open for you with the necessary rollback patch to apply to your 3.4 release branch. http://bugs.python.org/issue20651 This particular issue is actually solved in default, 3.3 and 2.7 as benjamin did the backouts/rollbacks of the pro

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Larry Hastings added the comment: Any progress to report? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Gregory P. Smith added the comment: Thanks for trying. :) I've got a complicated "test" case of zipping up the stdlib into python27.zip and running the Python test suite against that which also tends to trigger the bugs. Some tests failing with SystemError and such. It smells like a memory cor

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Paul Moore added the comment: Re unit tests. Doh. Of *course* there are tests for importing from zipfiles. And I just ran them (on Windows) and they worked. So there's something more complex going on here and I don't know how you test for it, sorry (short of by trying an import from the pip wh

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Paul Moore added the comment: I have reports from virtualenv users that this is not happening on Linux, BTW. Could it be platform-specific somehow? Have the Unix users here been able to reproduce this? As regards a unit test, presumably we could ship a preconstructed zipfile in the test suite

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

STINNER Victor added the comment: Does anyone know how to write a unit test to ensure that the regression will not be reintroduced later? -- nosy: +haypo ___ Python tracker ___

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Paul Moore added the comment: Will someone make sure this gets logged the way it needs to for Larry's 3.4rc2 cherrypick process? Ta. -- ___ Python tracker ___ __

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Gregory P. Smith added the comment: I believe this happens on all platforms. -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Paul Moore added the comment: Can anyone confirm if this is a Windows-only issue? I need to know whether I should block Python 3.3.4 in virtualenv for everyone, or just for Windows. I only have Windows I can test on. -- ___ Python tracker

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Gregory P. Smith added the comment: Confirmed that Modules/zipimport.c in the 3.3 and default branches is identical to the version from late last year. Both should be good for 3.3.5 and 3.4.0 releases. -- ___ Python tracker

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Benjamin Peterson added the comment: Okay, I backed out the world. -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Roundup Robot added the comment: New changeset 5330de5c9d2d by Benjamin Peterson in branch '3.3': backout 2807a5f011e4 for causing #20621 http://hg.python.org/cpython/rev/5330de5c9d2d New changeset 52ab9e1ff46a by Benjamin Peterson in branch 'default': merge backout for #20621 http://hg.python.o

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Georg Brandl added the comment: OK. What do you think about rolling a 3.3.5 rc1 release next weekend, with the final a week later? -- ___ Python tracker ___

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Paul Moore added the comment: OK, I can confirm that both the patches fix the issue when applied to the relevant branches. -- ___ Python tracker ___

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Gregory P. Smith added the comment: if you look at the zipimport.c file log there was one additional tiny change to fix a potential memory leak made after the change I suggested backing out: http://hg.python.org/cpython/log/fb5f4cfc3230/Modules/zipimport.c anyways, yes, backing up to the change

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Changes by Gregory P. Smith : Added file: http://bugs.python.org/file34103/issue20621-34-rollbacks-gps01.diff ___ Python tracker ___ ___ Pytho

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Paul Moore added the comment: OK, confirmed. Backing out to just before revision 2807a5f011e4 the problem has disappeared. Re-applying just 2807a5f011e4 causes the issue to appear again. -- ___ Python tracker ___

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Georg Brandl added the comment: Yeah, just tried the backout, it doesn't apply cleanly anymore -- Modules/zipimport.c has apparently changed some more afterwards. I think using the parent changeset is the best thing to do at the moment, until Greg comes up with a patch. -- assignee:

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Paul Moore added the comment: Georg - see http://bugs.python.org/issue20621#msg211209 for what I did. That shows backing out did *not* fix the issue. But I did backout on the default branch, and my backout may not have worked as I explained. I just tried to do hg backout on the 3.3 branch and

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Georg Brandl added the comment: Paul, could you confirm that backing out the 2807a5f011e4 changeset on the 3.3 branch fixes the problem? -- ___ Python tracker ___ __

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Paul Moore added the comment: Thanks for the workaround. I'm going to try to do some serious testing of all this over the weekend, I'll let you know how it goes. -- ___ Python tracker _

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Steve Dower added the comment: Oddly enough, this works with 3.3.4 as released: >>> import sys, zipfile >>> with zipfile.ZipFile('test.zip', 'w') as f: ... f.writestr('test/__init__.py', b'print("Success!")') ... >>> sys.path[:] = ['test.zip'] >>> import test Success! Maybe wheel is creating

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Steve Dower added the comment: I found that using zipimporter('...whl').load_module(pip) directly works fine, so you may be able to use that as a workaround. (Forgot to mention it in my initial comment, but that's what prompted me to check against the ABC.) I also backed out that change from t

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Paul Moore added the comment: Note - we're going to have to work around this bug in Virtualenv (even if it's just in code specific to 3.3.4) so a workaround for 3.3.4 and an explanation of what's going wrong would be useful, as well as a fix. -- ___

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Paul Moore added the comment: I tried hg backout 2807a5f011e4. It gave errors in the form of dialog boxes titled "Microsoft Visual Studio" saying "File '-nosplash' not found". I've no idea where these came from and whether they matter, but I tried clicking OK. Mercurial then said merging Lib/

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Paul Moore added the comment: OK, I have a build of 3.4 that shows the bug. How do I revert http://hg.python.org/cpython/rev/20b77ff040b6 ? hg backout -r 20b77ff040b6 says "abort: cannot backout a merge changeset". -- ___ Python tracker

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Paul Moore added the comment: I'm afraid I don't have things set up to do a Python build right now. I *might* have time later, and if so I'll give it a try, but I can't promise. Also, I haven't yet managed to show the issue on 3.4.0rc1, but that may be because my check wasn't as complete as St

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

Changes by Gregory P. Smith : -- title: Issue with zipimport in 3.3.4 -> Issue with zipimport in 3.3.4 and 3.4.0rc1 ___ Python tracker ___ __