[issue20493] asyncio: OverflowError('timeout is too large')

Changes by STINNER Victor : -- components: +Asyncio nosy: +yselivanov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue20493] asyncio: OverflowError('timeout is too large')

Roundup Robot added the comment: New changeset 41c6c066feb2 by Victor Stinner in branch '3.4': Issue #20493: Document that asyncio should not exceed one day http://hg.python.org/cpython/rev/41c6c066feb2 -- ___ Python tracker

[issue20493] asyncio: OverflowError('timeout is too large')

Roundup Robot added the comment: New changeset 79e5bb0d9b8e by Victor Stinner in branch 'default': Issue #20493: Document that asyncio should not exceed one day http://hg.python.org/cpython/rev/79e5bb0d9b8e -- nosy: +python-dev ___ Python tracker

[issue20493] asyncio: OverflowError('timeout is too large')

Guido van Rossum added the comment: For now, can we just add to the asyncio docs that timeouts shouldn't exceed one day? Then we can fix it later without breaking expectations. -- ___ Python tracker __

[issue20493] asyncio: OverflowError('timeout is too large')

STINNER Victor added the comment: > Of all these, 4194303 is the smallest, it's only 2**22-1, i.e. 48 days in the > future Maybe asyncio can uses a maximum timeout of 30 days? Or maybe even 1 day. Wake up every day to recompute the timeout should not kill the battery of your laptop or of you

[issue20493] asyncio: OverflowError('timeout is too large')

Guido van Rossum added the comment: I guess whenever you have a timeout like that it's the product of a bad calculation in the app (wouldn't be the first time that someone multiplied by 1000 instead of dividing to go from milliseconds to seconds :-). So it would be good to catch this in call_l

[issue20493] asyncio: OverflowError('timeout is too large')

Charles-François Natali added the comment: > Shouldn't this be fixed in the C implementation of the select module or in selectors.py? It seems likely that the exact range might be different for each syscall and possibly per OS or even OS version. Agreed: if we want to fix this, it should be done

[issue20493] asyncio: OverflowError('timeout is too large')

Guido van Rossum added the comment: Shouldn't this be fixed in the C implementation of the select module or in selectors.py? It seems likely that the exact range might be different for each syscall and possibly per OS or even OS version. -- ___ Pyth

[issue20493] asyncio: OverflowError('timeout is too large')

STINNER Victor added the comment: Attached patch fixes the issue, but it has no unit test :-( On Windows, it looks like IocpProactor can also raise an error if the timeout is too large: # GetQueuedCompletionStatus() has a resolution of 1 millisecond, # round away from z

[issue20493] asyncio: OverflowError('timeout is too large')

New submission from STINNER Victor: In asyncio, if the next event is in 2^40 seconds, epoll.poll() raises an OverflowError because epoll_wait() maximum value for the timeout is INT_MAX seconds. Test timeout_overflow.py to reproduce the issue. -- files: timeout_overflow.py messages: 21