[issue20287] Argument Clinic: support diverting output to buffer, external file, etc

Larry Hastings added the comment: Done! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue20287] Argument Clinic: support diverting output to buffer, external file, etc

Roundup Robot added the comment: New changeset 7f6712954d5d by Larry Hastings in branch 'default': Issue #20287: Argument Clinic's output is now configurable, allowing http://hg.python.org/cpython/rev/7f6712954d5d -- nosy: +python-dev ___ Python track

[issue20287] Argument Clinic: support diverting output to buffer, external file, etc

Larry Hastings added the comment: I have a fix already in place for the clinic_test.py problem. I disagree with your proposed "foo.c.clinic" nomenclature, and there are advantages to "foo.clinic.c": double-clicking on them will launch the correct editor, and editors will automatically color th

[issue20287] Argument Clinic: support diverting output to buffer, external file, etc

Serhiy Storchaka added the comment: The patch is too large and I don't very conversant with this code, so I just left several minor comments on Rietveld. At first glance all looks good. All works with my patches, results are good. But I see that side fail names have extension .clinic.c. The .c

[issue20287] Argument Clinic: support diverting output to buffer, external file, etc

Larry Hastings added the comment: I have backed out the "args" -> "_args" change. Not because I'm giving up on it, or that I necessarily think it's a bad idea, but because there are some changes happening in #20189 that will make it easier / that would conflict if I attacked it now. The resul

[issue20287] Argument Clinic: support diverting output to buffer, external file, etc

Larry Hastings added the comment: If I removed support for all destinations except files, I might be able to remove fifty lines or so. However, I'm not planning on doing that. Does cryptmodule.c, which has exactly one function, really need a 20-line separate file? Also, the "file" approach oft

[issue20287] Argument Clinic: support diverting output to buffer, external file, etc

Serhiy Storchaka added the comment: Can Argument Clinic be simplified when drop support for all alternative outputs besides a side file? > * "args" and "kwargs" variables in C renamed to "_args" and "_kwargs" Why this is needed? If buildin function has "args" or "kwargs" keyword arguments, C

[issue20287] Argument Clinic: support diverting output to buffer, external file, etc

Changes by Zachary Ware : -- nosy: +zach.ware ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue20287] Argument Clinic: support diverting output to buffer, external file, etc

New submission from Larry Hastings: The long-awaited, highly desirable "buffer" patch is here! With features I figured would never see the light of day. Changes in this patch: * New directive "output": output redirects a "field" (subsection of Clinic's generated code) to an alternat