[issue2016] Crash when modifying the **kwargs passed to a function.

Alexander Belopolsky added the comment: On Mon, Sep 20, 2010 at 10:23 AM, Mark Lawrence wrote: > > Mark Lawrence added the comment: > > Can someone please backport this to 2.7 so we can get this closed, thanks. > AFAICT, r73564 preceded 2.7 branch cut, so the fix is already in 2.7. -

[issue2016] Crash when modifying the **kwargs passed to a function.

Amaury Forgeot d'Arc added the comment: The fix was applied to trunk before the creation of the 2.7 branch. There is nothing to backport -- status: open -> closed ___ Python tracker

[issue2016] Crash when modifying the **kwargs passed to a function.

Mark Lawrence added the comment: Can someone please backport this to 2.7 so we can get this closed, thanks. -- nosy: +BreamoreBoy versions: +Python 2.7 -Python 2.6 ___ Python tracker ___

[issue2016] Crash when modifying the **kwargs passed to a function.

R. David Murray added the comment: It was merged to py3k in r73623, 3.1 in r73625, but not, as far as I can see, to 2.6. -- nosy: +r.david.murray stage: patch review -> commit review versions: -Python 2.5, Python 2.7, Python 3.0, Python 3.1 ___ Pyt

[issue2016] Crash when modifying the **kwargs passed to a function.

Terry J. Reedy added the comment: Is everything fixed, so this can be closed? -- nosy: +tjreedy status: pending -> open ___ Python tracker ___ ___

[issue2016] Crash when modifying the **kwargs passed to a function.

Amaury Forgeot d'Arc added the comment: Fixed in trunk with r73564. I performed performance tests: differences with pybench were negligible (<1%), but a specially crafted case like: kw = dict(a=1, b=2, c=3) for x in xrange(self.rounds): f(**kw) showed an improvement of 21%! Will b

[issue2016] Crash when modifying the **kwargs passed to a function.

Daniel Diniz added the comment: Confirmed in py3k (debug), trunk (non-debug) hangs with lots of CPU activity. py3k backtrace: #0 0x0805c196 in do_richcompare (v=0x83e734c, w=0xb7afa648, op=2) at Objects/object.c:561 #1 0x0805c450 in PyObject_RichCompare (v=0x83e734c, w=0xb7afa648, op=2) at Ob

[issue2016] Crash when modifying the **kwargs passed to a function.

Changes by Daniel Diniz <[EMAIL PROTECTED]>: -- nosy: +ajaksu2 ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing l

[issue2016] Crash when modifying the **kwargs passed to a function.

Alexander Belopolsky <[EMAIL PROTECTED]> added the comment: I am attaching my fix along the lines of a solution suggested by Amaury at http://mail.python.org/pipermail/python-dev/2008- February/076747.html: """ > Or is the proper fix to incref the values > going into the kw array and decref them

[issue2016] Crash when modifying the **kwargs passed to a function.

Martin v. Löwis added the comment: I think we agree that this patch has the potential of breaking existing valid code. So based on the policy that we should avoid doing so in a bugfix release, I'd rather reject that fix (fix2016.txt) for 2.5.x. OTOH, if it is really unlikely that is ever occurs i

[issue2016] Crash when modifying the **kwargs passed to a function.

Guido van Rossum added the comment: I have a proposed minimal fix, but I wonder if this would break existing code (apart from the exploit given here). Martin? (I think the discussion between Alexander and Amaury can be ignored for the purpose of reviewing the fix; only the exploit matters.) --

[issue2016] Crash when modifying the **kwargs passed to a function.

Changes by Gregory P. Smith: -- nosy: +gregory.p.smith __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue2016] Crash when modifying the **kwargs passed to a function.

Alexander Belopolsky added the comment: Sorry, please ignore my last comment about arg. The null and tuple checks are for argdefs, not arg. __ Tracker <[EMAIL PROTECTED]> __ __

[issue2016] Crash when modifying the **kwargs passed to a function.

Alexander Belopolsky added the comment: According to http://docs.python.org/api/object.html, """ PyObject* PyObject_Call(PyObject *callable_object, PyObject *args, PyObject *kw) Return value: New reference. Call a callable Python object callable_object, with arguments given by th

[issue2016] Crash when modifying the **kwargs passed to a function.

Amaury Forgeot d'Arc added the comment: This could be turned into an assertion. But beware that some extension writers may use code like PyObject_Call(callable, args, Py_None) which works perfectly today. __ Tracker <[EMAIL PROTECTED]>

[issue2016] Crash when modifying the **kwargs passed to a function.

Alexander Belopolsky added the comment: It also appears that the tuple and dict checks in function_call are redundant. If there is a use case that results in function_call getting anything (non null) other than dict and tuple in arg and kw, I don't think silently ignoring such arguments is the r

[issue2016] Crash when modifying the **kwargs passed to a function.

Changes by Christian Heimes: -- components: +Interpreter Core priority: -> high __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing

[issue2016] Crash when modifying the **kwargs passed to a function.

New submission from Amaury Forgeot d'Arc: The following script exploits a comment in funcobject.c: /* XXX This is broken if the caller deletes dict items! */ Because the code only borrows references to the items, it is possible to have them destroyed before they are copied into the called fram