[issue20122] Move CallTips tests to idle_tests

2014-01-20 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue20122] Move CallTips tests to idle_tests

2014-01-20 Thread Roundup Robot
Roundup Robot added the comment: New changeset f6f2d9d04cd0 by Terry Jan Reedy in branch '2.7': Issue #20122: Idlelib: Move tests in 3.x CallTips.py to test_calltips.py. http://hg.python.org/cpython/rev/f6f2d9d04cd0 New changeset 7befcc353d40 by Terry Jan Reedy in branch '3.3': Issue #20122: Idl

[issue20122] Move CallTips tests to idle_tests

2014-01-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: Attached is patch for 2.7 with all tests passing. 3.x get_argspec cannot replace 2.x get_arg_text because it uses inspect.getfullargspec, which does not exist in 2.7. (Its use made the code simpler.) Besides minor changes in test_calltips.py, I made 3 changes

[issue20122] Move CallTips tests to idle_tests

2014-01-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: Attached patch moves all tests, changed (and simplified) to call get_argspec directly. I will apply after I get tk 8.6 to test with 3.4. -- Added file: http://bugs.python.org/file33536/test_calltips-33.diff ___ Pytho

[issue20122] Move CallTips tests to idle_tests

2014-01-09 Thread Terry J. Reedy
Terry J. Reedy added the comment: The existing tests in CallTips.py, half of which I wrote based on the ones that existed, have one or two deficiencies that are copied in the patch. First, they are not proper unittests. They test get_argspec indirectly by calling .fetch_tip and get_entity. Thi

[issue20122] Move CallTips tests to idle_tests

2014-01-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: It is a good idea to make this a separate patch;-). Will look carefully after sleep. -- assignee: -> terry.reedy ___ Python tracker ___ __

[issue20122] Move CallTips tests to idle_tests

2014-01-04 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Proposed patch moves CallTips tests from Lib/idlelib/CallTips.py to Lib/idlelib/idle_test/test_calltips.py and converts them to unittests. Private keyword-only parameter _namespace was added to fetch_tip() and get_entity(). -- components: IDLE, Te