[issue20102] shutil._make_zipfile possible resource leak

2014-02-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 767d034b3feb by Benjamin Peterson in branch '2.7': use with statement to ensure zipfile is always closed (closes #20102) http://hg.python.org/cpython/rev/767d034b3feb New changeset 838674d15b5b by Benjamin Peterson in branch '3.3': use with statemen

[issue20102] shutil._make_zipfile possible resource leak

2014-01-01 Thread Peter Santoro
New submission from Peter Santoro: Now that zipfile.ZipFile supports the context manager protocol, shouldn't shutil._make_zipfile make use of it to avoid the possibility of the archive file not being closed properly if an exception occurs? It should be noted that shutil._unpack_zipfile does us