[issue20097] Bad use of `self` in importlib

2014-01-02 Thread Eric Snow
Eric Snow added the comment: Thanks for the review, Victor. As to that note, it is the subject of issue #19714. -- assignee: brett.cannon -> eric.snow dependencies: -Add tests for importlib.machinery.WindowsRegistryFinder resolution: -> fixed stage: patch review -> committed/rejected

[issue20097] Bad use of `self` in importlib

2014-01-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7dbb4c6cd30e by Eric Snow in branch 'default': Issue #20097: Fix bad use of "self" in importlib's WindowsRegistryFinder. http://hg.python.org/cpython/rev/7dbb4c6cd30e -- nosy: +python-dev ___ Python track

[issue20097] Bad use of `self` in importlib

2014-01-02 Thread STINNER Victor
STINNER Victor added the comment: Would it be possible to put @unittest.skipUnless(...) on WindowsRegistryFinderTests instead of duplicating it? Except of this nit, the patch looks good to me. Note: WindowsRegistryFinder.find_spec() contains the comment: # XXX untested! Need a Windows pers

[issue20097] Bad use of `self` in importlib

2014-01-01 Thread Eric Snow
Eric Snow added the comment: Here's an updated patch that fixes as copy-and-paste mistake. -- Added file: http://bugs.python.org/file33295/issue20097-tests.diff ___ Python tracker __

[issue20097] Bad use of `self` in importlib

2014-01-01 Thread Eric Snow
Changes by Eric Snow : Removed file: http://bugs.python.org/file33294/issue20097-tests.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue20097] Bad use of `self` in importlib

2014-01-01 Thread Eric Snow
Eric Snow added the comment: The patch passes on my linux box and on my windows 7 laptop (using Visual Studio 2010 Express). -- ___ Python tracker ___ __

[issue20097] Bad use of `self` in importlib

2014-01-01 Thread Eric Snow
Eric Snow added the comment: Here's a patch with tests that cover find_module() and find_spec() for WindowsRegistryFinder (the missing case) and fixes the bug. -- keywords: +patch nosy: +eric.snow stage: test needed -> patch review Added file: http://bugs.python.org/file33294/issue20097

[issue20097] Bad use of `self` in importlib

2013-12-30 Thread Brett Cannon
Changes by Brett Cannon : -- dependencies: +Add tests for importlib.machinery.WindowsRegistryFinder ___ Python tracker ___ ___ Python-

[issue20097] Bad use of `self` in importlib

2013-12-30 Thread Brett Cannon
Changes by Brett Cannon : -- stage: needs patch -> test needed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20097] Bad use of `self` in importlib

2013-12-30 Thread Christian Heimes
Christian Heimes added the comment: Thanks! :) -- assignee: -> brett.cannon nosy: +brett.cannon stage: -> needs patch ___ Python tracker ___ ___

[issue20097] Bad use of `self` in importlib

2013-12-30 Thread Ram Rachum
Ram Rachum added the comment: Sorry, bad link, this is the right link: http://hg.python.org/cpython/file/fd846837492d/Lib/importlib/_bootstrap.py#l1409 -- ___ Python tracker ___

[issue20097] Bad use of `self` in importlib

2013-12-30 Thread Christian Heimes
Christian Heimes added the comment: I don't see a class method at line 1431. -- nosy: +christian.heimes ___ Python tracker ___ ___ Pyt

[issue20097] Bad use of `self` in importlib

2013-12-30 Thread Ram Rachum
New submission from Ram Rachum: There's a bad usage of `self` here: http://hg.python.org/cpython/file/fd846837492d/Lib/importlib/_bootstrap.py#l1431 `self` isn't defined because it's a class method. -- components: Library (Lib) messages: 207105 nosy: cool-RR priority: normal sever