[issue19925] Add unit test for spwd module

2014-05-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Committed with some changes. geteuid() is used instead getuid(), and checked that os.geteuid exists (see test_shutil). Checked deprecated attributes sp_nam and sp_pwd. Added tests for the calling getspnam() with wrong number of arguments and with bytes (on 3

[issue19925] Add unit test for spwd module

2014-05-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset c35274fe5b35 by Serhiy Storchaka in branch '2.7': Issue #19925: Added tests for the spwd module. Original patch by Vajrasky Kok. http://hg.python.org/cpython/rev/c35274fe5b35 New changeset 9bdbe0b08dff by Serhiy Storchaka in branch '3.4': Issue #199

[issue19925] Add unit test for spwd module

2014-05-25 Thread Vajrasky Kok
Vajrasky Kok added the comment: Thanks, Serhiy, for the review! Here is the updated patch. -- Added file: http://bugs.python.org/file35347/unittest_for_spwd_v3.patch ___ Python tracker _

[issue19925] Add unit test for spwd module

2014-05-25 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka type: -> enhancement versions: +Python 2.7, Python 3.5 ___ Python tracker ___ ___

[issue19925] Add unit test for spwd module

2013-12-08 Thread Vajrasky Kok
Vajrasky Kok added the comment: Hi Claudiu, thanks for the review and the knowledge that on Windows, we don't have attribute getuid of os. Here is the updated patch. I do not check specifically for Windows but only whether the platform can import spwd module or not. That should be enough. ---

[issue19925] Add unit test for spwd module

2013-12-07 Thread Claudiu.Popa
Claudiu.Popa added the comment: Hi. I left a comment on Rietveld. -- nosy: +Claudiu.Popa ___ Python tracker ___ ___ Python-bugs-list m

[issue19925] Add unit test for spwd module

2013-12-07 Thread Vajrasky Kok
Changes by Vajrasky Kok : Added file: http://bugs.python.org/file33035/unittest_for_spwd.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue19925] Add unit test for spwd module

2013-12-07 Thread Vajrasky Kok
Changes by Vajrasky Kok : Removed file: http://bugs.python.org/file33034/unittest_for_spwd.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue19925] Add unit test for spwd module

2013-12-07 Thread Vajrasky Kok
New submission from Vajrasky Kok: So we may have buildbot with root account after all. https://mail.python.org/pipermail/python-dev/2013-December/130708.html So here is the unit test for spwd module that requires root account. -- components: Tests files: unittest_for_spwd.patch keyword